Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4560)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
index 9257c9bdd1f940ebd34427627608ccf8ed166b1b..8c783b5e2ff443263fceb8aecfb4efdcb41b63eb 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
@@ -887,7 +887,7 @@ void PrintPreviewHandler::HandlePrint(const base::ListValue* args) {
!settings->GetInteger(printing::kSettingPageHeight, &height) ||
width <= 0 || height <= 0) {
NOTREACHED();
- base::FundamentalValue http_code_value(-1);
+ base::Value http_code_value(-1);
web_ui()->CallJavascriptFunctionUnsafe("onPrivetPrintFailed",
http_code_value);
return;
@@ -1606,7 +1606,7 @@ void PrintPreviewHandler::StartPrivetLocalPrint(const std::string& print_ticket,
base::string16 title;
if (!GetPreviewDataAndTitle(&data, &title)) {
- base::FundamentalValue http_code_value(-1);
+ base::Value http_code_value(-1);
web_ui()->CallJavascriptFunctionUnsafe("onPrivetPrintFailed",
http_code_value);
return;
@@ -1705,7 +1705,7 @@ void PrintPreviewHandler::OnPrivetPrintingDone(
void PrintPreviewHandler::OnPrivetPrintingError(
const cloud_print::PrivetLocalPrintOperation* print_operation,
int http_code) {
- base::FundamentalValue http_code_value(http_code);
+ base::Value http_code_value(http_code);
web_ui()->CallJavascriptFunctionUnsafe("onPrivetPrintFailed",
http_code_value);
}
@@ -1740,7 +1740,7 @@ void PrintPreviewHandler::OnGotPrintersForExtension(
const base::ListValue& printers,
bool done) {
web_ui()->CallJavascriptFunctionUnsafe("onExtensionPrintersAdded", printers,
- base::FundamentalValue(done));
+ base::Value(done));
}
void PrintPreviewHandler::OnGotExtensionPrinterInfo(
« no previous file with comments | « chrome/browser/ui/webui/policy_ui_browsertest.cc ('k') | chrome/browser/ui/webui/print_preview/print_preview_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698