Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3861)

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc
diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
index e159a35149a771adab1bb97e9cf3217f2f57b843..416515f56adf295633ab49f1be2e1569687d3ec1 100644
--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
@@ -110,17 +110,15 @@ void ClearBrowserDataHandler::InitializeHandler() {
void ClearBrowserDataHandler::InitializePage() {
web_ui()->CallJavascriptFunctionUnsafe(
- "ClearBrowserDataOverlay.createFooter",
- base::FundamentalValue(AreCountersEnabled()),
- base::FundamentalValue(sync_service_ && sync_service_->IsSyncActive()),
- base::FundamentalValue(should_show_history_notice_));
+ "ClearBrowserDataOverlay.createFooter", base::Value(AreCountersEnabled()),
+ base::Value(sync_service_ && sync_service_->IsSyncActive()),
+ base::Value(should_show_history_notice_));
RefreshHistoryNotice();
UpdateInfoBannerVisibility();
OnBrowsingHistoryPrefChanged();
bool removal_in_progress = !!remover_;
- web_ui()->CallJavascriptFunctionUnsafe(
- "ClearBrowserDataOverlay.setClearing",
- base::FundamentalValue(removal_in_progress));
+ web_ui()->CallJavascriptFunctionUnsafe("ClearBrowserDataOverlay.setClearing",
+ base::Value(removal_in_progress));
web_ui()->CallJavascriptFunctionUnsafe(
"ClearBrowserDataOverlay.markInitializationComplete");
@@ -363,13 +361,13 @@ void ClearBrowserDataHandler::OnBrowsingDataRemoverDone() {
"History.ClearBrowsingData.ShownHistoryNoticeAfterClearing", show_notice);
web_ui()->CallJavascriptFunctionUnsafe("ClearBrowserDataOverlay.doneClearing",
- base::FundamentalValue(show_notice));
+ base::Value(show_notice));
}
void ClearBrowserDataHandler::OnBrowsingHistoryPrefChanged() {
web_ui()->CallJavascriptFunctionUnsafe(
"ClearBrowserDataOverlay.setAllowDeletingHistory",
- base::FundamentalValue(*allow_deleting_browser_history_));
+ base::Value(*allow_deleting_browser_history_));
}
void ClearBrowserDataHandler::AddCounter(
@@ -398,8 +396,8 @@ void ClearBrowserDataHandler::OnStateChanged(syncer::SyncService* sync) {
void ClearBrowserDataHandler::UpdateSyncState() {
web_ui()->CallJavascriptFunctionUnsafe(
"ClearBrowserDataOverlay.updateSyncWarningAndHistoryFooter",
- base::FundamentalValue(sync_service_ && sync_service_->IsSyncActive()),
- base::FundamentalValue(should_show_history_notice_));
+ base::Value(sync_service_ && sync_service_->IsSyncActive()),
+ base::Value(should_show_history_notice_));
}
void ClearBrowserDataHandler::RefreshHistoryNotice() {

Powered by Google App Engine
This is Rietveld 408576698