Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4446)

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/app_launcher_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
index 42dd7b55402a79420098cded4c1b89ee92d74f9b..fae9d149b036b2b6e4cc7be84751f6943a6e5798 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
@@ -335,8 +335,8 @@ void AppLauncherHandler::OnExtensionLoaded(
visible_apps_.insert(extension->id());
ExtensionPrefs* prefs = ExtensionPrefs::Get(extension_service_->profile());
- base::FundamentalValue highlight(prefs->IsFromBookmark(extension->id()) &&
- attempted_bookmark_app_install_);
+ base::Value highlight(prefs->IsFromBookmark(extension->id()) &&
+ attempted_bookmark_app_install_);
attempted_bookmark_app_install_ = false;
web_ui()->CallJavascriptFunctionUnsafe("ntp.appAdded", *app_info, highlight);
}
@@ -797,7 +797,7 @@ void AppLauncherHandler::OnLocalStatePreferenceChanged() {
#if BUILDFLAG(ENABLE_APP_LIST)
web_ui()->CallJavascriptFunctionUnsafe(
"ntp.appLauncherPromoPrefChangeCallback",
- base::FundamentalValue(g_browser_process->local_state()->GetBoolean(
+ base::Value(g_browser_process->local_state()->GetBoolean(
prefs::kShowAppLauncherPromo)));
#endif
}
@@ -876,8 +876,8 @@ void AppLauncherHandler::AppRemoved(const Extension* extension,
return;
web_ui()->CallJavascriptFunctionUnsafe(
- "ntp.appRemoved", *app_info, base::FundamentalValue(is_uninstall),
- base::FundamentalValue(!extension_id_prompting_.empty()));
+ "ntp.appRemoved", *app_info, base::Value(is_uninstall),
+ base::Value(!extension_id_prompting_.empty()));
}
bool AppLauncherHandler::ShouldShow(const Extension* extension) const {

Powered by Google App Engine
This is Rietveld 408576698