Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
diff --git a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
index caf07f69197c0a97b7f85dcfd48d2d0b8cd193aa..f9ea5862b789886b1d9542fb38810a42c72466ae 100644
--- a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
+++ b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
@@ -129,7 +129,7 @@ void DownloadsListTracker::StartAndSendChunk() {
web_ui_->CallJavascriptFunctionUnsafe(
"downloads.Manager.insertItems",
- base::FundamentalValue(static_cast<int>(sent_to_page_)), list);
+ base::Value(static_cast<int>(sent_to_page_)), list);
sent_to_page_ += list.GetSize();
}
@@ -389,9 +389,9 @@ void DownloadsListTracker::InsertItem(const SortedSet::iterator& insert) {
base::ListValue list;
list.Append(CreateDownloadItemValue(*insert));
- web_ui_->CallJavascriptFunctionUnsafe(
- "downloads.Manager.insertItems",
- base::FundamentalValue(static_cast<int>(index)), list);
+ web_ui_->CallJavascriptFunctionUnsafe("downloads.Manager.insertItems",
+ base::Value(static_cast<int>(index)),
+ list);
sent_to_page_++;
}
@@ -402,7 +402,7 @@ void DownloadsListTracker::UpdateItem(const SortedSet::iterator& update) {
web_ui_->CallJavascriptFunctionUnsafe(
"downloads.Manager.updateItem",
- base::FundamentalValue(static_cast<int>(GetIndex(update))),
+ base::Value(static_cast<int>(GetIndex(update))),
*CreateDownloadItemValue(*update));
}
@@ -416,8 +416,7 @@ void DownloadsListTracker::RemoveItem(const SortedSet::iterator& remove) {
size_t index = GetIndex(remove);
if (index < sent_to_page_) {
web_ui_->CallJavascriptFunctionUnsafe(
- "downloads.Manager.removeItem",
- base::FundamentalValue(static_cast<int>(index)));
+ "downloads.Manager.removeItem", base::Value(static_cast<int>(index)));
sent_to_page_--;
}
}

Powered by Google App Engine
This is Rietveld 408576698