Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3732)

Unified Diff: chrome/browser/ui/webui/help/help_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/crashes_ui.cc ('k') | chrome/browser/ui/webui/history_login_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/help/help_handler.cc
diff --git a/chrome/browser/ui/webui/help/help_handler.cc b/chrome/browser/ui/webui/help/help_handler.cc
index fd47ef591d9d351a0474fd9b991aaf2d931960b5..de911086f592c8d05277a820417ae5708f4ffcf8 100644
--- a/chrome/browser/ui/webui/help/help_handler.cc
+++ b/chrome/browser/ui/webui/help/help_handler.cc
@@ -478,7 +478,7 @@ void HelpHandler::OnPageLoaded(const base::ListValue* args) {
web_ui()->CallJavascriptFunctionUnsafe(
"help.HelpPage.updateEnableReleaseChannel",
- base::FundamentalValue(CanChangeChannel(Profile::FromWebUI(web_ui()))));
+ base::Value(CanChangeChannel(Profile::FromWebUI(web_ui()))));
base::Time build_time = base::SysInfo::GetLsbReleaseTime();
base::string16 build_date = base::TimeFormatFriendlyDate(build_time);
@@ -490,16 +490,16 @@ void HelpHandler::OnPageLoaded(const base::ListValue* args) {
web_ui()->CallJavascriptFunctionUnsafe(
"help.HelpPage.setObsoleteSystem",
- base::FundamentalValue(ObsoleteSystem::IsObsoleteNowOrSoon()));
+ base::Value(ObsoleteSystem::IsObsoleteNowOrSoon()));
web_ui()->CallJavascriptFunctionUnsafe(
"help.HelpPage.setObsoleteSystemEndOfTheLine",
- base::FundamentalValue(ObsoleteSystem::IsObsoleteNowOrSoon() &&
- ObsoleteSystem::IsEndOfTheLine()));
+ base::Value(ObsoleteSystem::IsObsoleteNowOrSoon() &&
+ ObsoleteSystem::IsEndOfTheLine()));
#if defined(OS_CHROMEOS)
web_ui()->CallJavascriptFunctionUnsafe(
"help.HelpPage.updateIsEnterpriseManaged",
- base::FundamentalValue(IsEnterpriseManaged()));
+ base::Value(IsEnterpriseManaged()));
// First argument to GetChannel() is a flag that indicates whether
// current channel should be returned (if true) or target channel
// (otherwise).
@@ -642,7 +642,7 @@ void HelpHandler::SetUpdateStatus(VersionUpdater::Status status,
if (status == VersionUpdater::UPDATING) {
web_ui()->CallJavascriptFunctionUnsafe("help.HelpPage.setProgress",
- base::FundamentalValue(progress));
+ base::Value(progress));
}
#if defined(OS_CHROMEOS)
@@ -655,13 +655,11 @@ void HelpHandler::SetUpdateStatus(VersionUpdater::Status status,
base::StringValue(types_msg));
} else {
web_ui()->CallJavascriptFunctionUnsafe(
- "help.HelpPage.showAllowedConnectionTypesMsg",
- base::FundamentalValue(false));
+ "help.HelpPage.showAllowedConnectionTypesMsg", base::Value(false));
}
} else {
web_ui()->CallJavascriptFunctionUnsafe(
- "help.HelpPage.showAllowedConnectionTypesMsg",
- base::FundamentalValue(false));
+ "help.HelpPage.showAllowedConnectionTypesMsg", base::Value(false));
}
#endif // defined(OS_CHROMEOS)
}
« no previous file with comments | « chrome/browser/ui/webui/crashes_ui.cc ('k') | chrome/browser/ui/webui/history_login_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698