Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2846)

Unified Diff: chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc b/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
index fcd76e36fe5083c340a8ca31c13453d7474ab55a..1bff6a9351b59ca5ce9661c8a559176f5e97363d 100644
--- a/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
@@ -523,7 +523,7 @@ void MobileSetupHandler::HandleGetDeviceInfo(const base::ListValue* args) {
// For non-LTE networks network state is ignored, so report the portal is
// reachable, so it gets shown.
web_ui()->CallJavascriptFunctionUnsafe(kJsConnectivityChangedCallback,
- base::FundamentalValue(true));
+ base::Value(true));
}
}
@@ -603,9 +603,8 @@ void MobileSetupHandler::UpdatePortalReachability(
nsh->DefaultNetwork()->connection_state() == shill::kStateOnline));
if (force_notification || portal_reachable != lte_portal_reachable_) {
- web_ui()->CallJavascriptFunctionUnsafe(
- kJsConnectivityChangedCallback,
- base::FundamentalValue(portal_reachable));
+ web_ui()->CallJavascriptFunctionUnsafe(kJsConnectivityChangedCallback,
+ base::Value(portal_reachable));
}
lte_portal_reachable_ = portal_reachable;
@@ -638,7 +637,7 @@ void MobileSetupUI::DidFinishNavigation(
}
if (navigation_handle->IsErrorPage()) {
- base::FundamentalValue result_value(-navigation_handle->GetNetErrorCode());
+ base::Value result_value(-navigation_handle->GetNetErrorCode());
web_ui()->CallJavascriptFunctionUnsafe(kJsPortalFrameLoadFailedCallback,
result_value);
return;
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc ('k') | chrome/browser/ui/webui/chromeos/slow_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698