chrome/browser/ui/webui/app_launcher_login_handler.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/app_launcher_login_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/app_launcher_login_handler.cc

diff --git a/chrome/browser/ui/webui/app_launcher_login_handler.cc b/chrome/browser/ui/webui/app_launcher_login_handler.cc

index 876e5975192c705dd3468c4da2cbdaafc43416b8..25ea3be0a67c4cec644fbdd72bb70942715381a3 100644

--- a/chrome/browser/ui/webui/app_launcher_login_handler.cc

+++ b/chrome/browser/ui/webui/app_launcher_login_handler.cc

@@ -223,7 +223,7 @@ void AppLauncherLoginHandler::UpdateLogin() {

base::StringValue header_value(header);

base::StringValue sub_header_value(sub_header);

base::StringValue icon_url_value(icon_url);

- base::FundamentalValue is_user_signed_in(!username.empty());

+ base::Value is_user_signed_in(!username.empty());

web_ui()->CallJavascriptFunctionUnsafe("ntp.updateLogin", header_value,

sub_header_value, icon_url_value,

is_user_signed_in);