chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_unittest.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/legacy/supervised_user_registration_utility.cc ('k') | chrome/browser/supervised_user/supervised_user_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_unittest.cc

diff --git a/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_unittest.cc b/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_unittest.cc

index 2e799939d057d7ed9ed9e4c11fe54f00a8379756..cfed6f0f2a7efd5fd6b7bc1e8288a311511947db 100644

--- a/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_unittest.cc

+++ b/chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_unittest.cc

@@ -22,7 +22,6 @@

#include "testing/gtest/include/gtest/gtest.h"

using base::DictionaryValue;

-using base::FundamentalValue;

using base::StringValue;

using base::Value;

using sync_pb::ManagedUserSharedSettingSpecifics;

@@ -162,12 +161,12 @@ TEST_F(SupervisedUserSharedSettingsServiceTest, SetAndGet) {

const char kIdC[] = "cccccc";

StringValue name("Jack");

- FundamentalValue age(8);

+ Value age(8);

StringValue bar("bar");

settings_service_.SetValue(kIdA, "name", name);

ASSERT_EQ(1u, sync_processor_->changes().size());

VerifySyncChangesAndClear();

- settings_service_.SetValue(kIdA, "age", FundamentalValue(6));

+ settings_service_.SetValue(kIdA, "age", Value(6));

ASSERT_EQ(1u, sync_processor_->changes().size());

VerifySyncChangesAndClear();

settings_service_.SetValue(kIdA, "age", age);

@@ -202,7 +201,7 @@ TEST_F(SupervisedUserSharedSettingsServiceTest, Merge) {

const char kIdB[] = "bbbbbb";

const char kIdC[] = "cccccc";

- FundamentalValue age(8);

+ Value age(8);

StringValue bar("bar");

settings_service_.SetValue(kIdA, "name", StringValue("Jack"));

settings_service_.SetValue(kIdA, "age", age);

@@ -252,7 +251,7 @@ TEST_F(SupervisedUserSharedSettingsServiceTest, ProcessChanges) {

const char kIdB[] = "bbbbbb";

const char kIdC[] = "cccccc";

- FundamentalValue age(8);

+ Value age(8);

StringValue bar("bar");

settings_service_.SetValue(kIdA, "name", StringValue("Jack"));

settings_service_.SetValue(kIdA, "age", age);