Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1538)

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc
diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc
index f8d1c524d62136ed374b0969bc0d3bb224c83836..a7f92acbf050c733fbaaddd3e02ff59b75b5df06 100644
--- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc
+++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc
@@ -281,8 +281,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyDisabled) {
profile_.GetTestingPrefService();
prefs->SetUserPref(prefs::kCloudPrintEmail,
new base::StringValue(std::string()));
- prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
- new base::FundamentalValue(false));
+ prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
service.Initialize();
@@ -300,8 +299,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyEnabled) {
profile_.GetTestingPrefService();
prefs->SetUserPref(prefs::kCloudPrintEmail,
new base::StringValue(std::string()));
- prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
- new base::FundamentalValue(false));
+ prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
service.Initialize();
@@ -324,8 +322,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenSetPolicy) {
EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
- prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
- new base::FundamentalValue(false));
+ prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
}
@@ -348,8 +345,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabledThenSetPolicy) {
prefs->GetString(prefs::kCloudPrintEmail));
service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
- prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
- new base::FundamentalValue(false));
+ prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
}
@@ -365,8 +361,7 @@ TEST_F(CloudPrintProxyPolicyTest,
profile_.GetTestingPrefService();
prefs->SetUserPref(prefs::kCloudPrintEmail,
new base::StringValue(std::string()));
- prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
- new base::FundamentalValue(false));
+ prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
service.Initialize();
@@ -387,8 +382,7 @@ TEST_F(CloudPrintProxyPolicyTest,
profile_.GetTestingPrefService();
prefs->SetUserPref(prefs::kCloudPrintEmail,
new base::StringValue(std::string()));
- prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
- new base::FundamentalValue(false));
+ prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
service.Initialize();
@@ -431,8 +425,7 @@ TEST_F(CloudPrintProxyPolicyTest,
profile_.GetTestingPrefService();
prefs->SetUserPref(prefs::kCloudPrintEmail,
new base::StringValue(std::string()));
- prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
- new base::FundamentalValue(false));
+ prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
service.Initialize();

Powered by Google App Engine
This is Rietveld 408576698