Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Unified Diff: chrome/browser/prefs/incognito_mode_prefs_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/incognito_mode_prefs_unittest.cc
diff --git a/chrome/browser/prefs/incognito_mode_prefs_unittest.cc b/chrome/browser/prefs/incognito_mode_prefs_unittest.cc
index 7637c6fdb2031e5d2604ac04475902e3f4475f6c..96f50d61a6d95bc2d7e96078a86613a1457bec24 100644
--- a/chrome/browser/prefs/incognito_mode_prefs_unittest.cc
+++ b/chrome/browser/prefs/incognito_mode_prefs_unittest.cc
@@ -39,17 +39,17 @@ TEST_F(IncognitoModePrefsTest, IntToAvailability) {
TEST_F(IncognitoModePrefsTest, GetAvailability) {
prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
- new base::FundamentalValue(IncognitoModePrefs::ENABLED));
+ new base::Value(IncognitoModePrefs::ENABLED));
EXPECT_EQ(IncognitoModePrefs::ENABLED,
IncognitoModePrefs::GetAvailability(&prefs_));
prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
- new base::FundamentalValue(IncognitoModePrefs::DISABLED));
+ new base::Value(IncognitoModePrefs::DISABLED));
EXPECT_EQ(IncognitoModePrefs::DISABLED,
IncognitoModePrefs::GetAvailability(&prefs_));
prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
- new base::FundamentalValue(IncognitoModePrefs::FORCED));
+ new base::Value(IncognitoModePrefs::FORCED));
EXPECT_EQ(IncognitoModePrefs::FORCED,
IncognitoModePrefs::GetAvailability(&prefs_));
}
@@ -57,8 +57,7 @@ TEST_F(IncognitoModePrefsTest, GetAvailability) {
typedef IncognitoModePrefsTest IncognitoModePrefsDeathTest;
TEST_F(IncognitoModePrefsDeathTest, GetAvailabilityBadValue) {
- prefs_.SetUserPref(prefs::kIncognitoModeAvailability,
- new base::FundamentalValue(-1));
+ prefs_.SetUserPref(prefs::kIncognitoModeAvailability, new base::Value(-1));
EXPECT_DCHECK_DEATH({
IncognitoModePrefs::Availability availability =
IncognitoModePrefs::GetAvailability(&prefs_);
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_unittest.cc ('k') | chrome/browser/prefs/preferences_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698