Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
index e8aeee5bad1f5bbabf30b3d9c5db44d4b7913db4..7b8d6b5058ab12885dcbd4bf433636cc526fb6d5 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
@@ -305,10 +305,10 @@ TEST_F(ChromePasswordManagerClientTest,
// preference.
ChromePasswordManagerClient* client = GetClient();
prefs()->SetUserPref(password_manager::prefs::kCredentialsEnableService,
- new base::FundamentalValue(true));
+ new base::Value(true));
EXPECT_TRUE(client->IsSavingAndFillingEnabledForCurrentPage());
prefs()->SetUserPref(password_manager::prefs::kCredentialsEnableService,
- new base::FundamentalValue(false));
+ new base::Value(false));
EXPECT_FALSE(client->IsSavingAndFillingEnabledForCurrentPage());
}
@@ -327,7 +327,7 @@ TEST_F(ChromePasswordManagerClientTest, SavingAndFillingEnabledConditionsTest) {
// Functionality disabled if there are SSL errors and the manager itself is
// disabled.
prefs()->SetUserPref(password_manager::prefs::kCredentialsEnableService,
- new base::FundamentalValue(false));
+ new base::Value(false));
EXPECT_FALSE(client->IsSavingAndFillingEnabledForCurrentPage());
EXPECT_FALSE(client->IsFillingEnabledForCurrentPage());
@@ -336,7 +336,7 @@ TEST_F(ChromePasswordManagerClientTest, SavingAndFillingEnabledConditionsTest) {
EXPECT_CALL(*client, DidLastPageLoadEncounterSSLErrors())
.WillRepeatedly(Return(false));
prefs()->SetUserPref(password_manager::prefs::kCredentialsEnableService,
- new base::FundamentalValue(false));
+ new base::Value(false));
EXPECT_FALSE(client->IsSavingAndFillingEnabledForCurrentPage());
EXPECT_TRUE(client->IsFillingEnabledForCurrentPage());
@@ -345,7 +345,7 @@ TEST_F(ChromePasswordManagerClientTest, SavingAndFillingEnabledConditionsTest) {
EXPECT_CALL(*client, DidLastPageLoadEncounterSSLErrors())
.WillRepeatedly(Return(false));
prefs()->SetUserPref(password_manager::prefs::kCredentialsEnableService,
- new base::FundamentalValue(true));
+ new base::Value(true));
EXPECT_TRUE(client->IsSavingAndFillingEnabledForCurrentPage());
EXPECT_TRUE(client->IsFillingEnabledForCurrentPage());
@@ -357,7 +357,7 @@ TEST_F(ChromePasswordManagerClientTest, SavingAndFillingEnabledConditionsTest) {
// Functionality disabled in Incognito mode also when manager itself is
// enabled.
prefs()->SetUserPref(password_manager::prefs::kCredentialsEnableService,
- new base::FundamentalValue(true));
+ new base::Value(true));
EXPECT_FALSE(client->IsSavingAndFillingEnabledForCurrentPage());
EXPECT_TRUE(client->IsFillingEnabledForCurrentPage());
profile()->ForceIncognito(false);
« no previous file with comments | « chrome/browser/net/errorpage_browsertest.cc ('k') | chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698