chrome/browser/extensions/menu_manager.h - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager.h

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/menu_manager.h

diff --git a/chrome/browser/extensions/menu_manager.h b/chrome/browser/extensions/menu_manager.h

index 5b858d822c90ebf2d138d277758bad107028286a..ec9f8a428bb45db83c7de0965240a51ef047e3e8 100644

--- a/chrome/browser/extensions/menu_manager.h

+++ b/chrome/browser/extensions/menu_manager.h

@@ -145,7 +145,7 @@ class MenuItem {

std::unique_ptr<base::Value> ToValue() const {

return std::unique_ptr<base::Value>(

- new base::FundamentalValue(static_cast<int>(value_)));

+ new base::Value(static_cast<int>(value_)));

}

bool Populate(const base::Value& value) {