chrome/browser/extensions/api/storage/policy_value_store_unittest.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/settings_private/settings_private_delegate.cc ('k') | chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

index e8757e20e45327a2793d3f302fd11f73a3d6aa0e..ae8fbefa82a10384ebdf4e2bf57751ac4ca845b5 100644

--- a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

+++ b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

@@ -123,13 +123,13 @@ class PolicyValueStoreTest : public testing::Test {

TEST_F(PolicyValueStoreTest, DontProvideRecommendedPolicies) {

policy::PolicyMap policies;

- base::FundamentalValue expected(123);

+ base::Value expected(123);

policies.Set("must", policy::POLICY_LEVEL_MANDATORY,

policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

expected.CreateDeepCopy(), nullptr);

policies.Set("may", policy::POLICY_LEVEL_RECOMMENDED,

policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

- base::MakeUnique<base::FundamentalValue>(456), nullptr);

+ base::MakeUnique<base::Value>(456), nullptr);

store_->SetCurrentPolicy(policies);

ValueStore::ReadResult result = store_->Get();

ASSERT_TRUE(result->status().ok());