Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8024)

Unified Diff: chrome/browser/extensions/api/notifications/notifications_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notifications/notifications_api.cc
diff --git a/chrome/browser/extensions/api/notifications/notifications_api.cc b/chrome/browser/extensions/api/notifications/notifications_api.cc
index addcd1118d7a8cea2cffc1448aee5e18d1a88e39..cd435f5d0c6a9f86bc89245c801e83681d01ccf2 100644
--- a/chrome/browser/extensions/api/notifications/notifications_api.cc
+++ b/chrome/browser/extensions/api/notifications/notifications_api.cc
@@ -732,7 +732,7 @@ bool NotificationsUpdateFunction::RunNotificationsApi() {
CreateScopedIdentifier(extension_->id(), params_->notification_id),
NotificationUIManager::GetProfileID(GetProfile()));
if (!matched_notification) {
- SetResult(base::MakeUnique<base::FundamentalValue>(false));
+ SetResult(base::MakeUnique<base::Value>(false));
SendResponse(true);
return true;
}
@@ -746,8 +746,7 @@ bool NotificationsUpdateFunction::RunNotificationsApi() {
// TODO(dewittj): Add more human-readable error strings if this fails.
bool could_update_notification = UpdateNotification(
params_->notification_id, &params_->options, &notification);
- SetResult(
- base::MakeUnique<base::FundamentalValue>(could_update_notification));
+ SetResult(base::MakeUnique<base::Value>(could_update_notification));
if (!could_update_notification)
return false;
@@ -771,7 +770,7 @@ bool NotificationsClearFunction::RunNotificationsApi() {
CreateScopedIdentifier(extension_->id(), params_->notification_id),
NotificationUIManager::GetProfileID(GetProfile()));
- SetResult(base::MakeUnique<base::FundamentalValue>(cancel_result));
+ SetResult(base::MakeUnique<base::Value>(cancel_result));
SendResponse(true);
return true;

Powered by Google App Engine
This is Rietveld 408576698