chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/instance_id/instance_id_api.cc ('k') | chrome/browser/extensions/api/media_galleries/media_galleries_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc

diff --git a/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc b/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc

index 6e24dec81384b38ec42705d123536066ef8c8136..514a1be373a2d7b9398835617b0447b97254d433 100644

--- a/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc

+++ b/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc

@@ -403,8 +403,7 @@ LanguageSettingsPrivateAddSpellcheckWordFunction::Run() {

SpellcheckServiceFactory::GetForContext(browser_context());

bool success = service->GetCustomDictionary()->AddWord(params->word);

- return RespondNow(

- OneArgument(base::MakeUnique<base::FundamentalValue>(success)));

+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(success)));

}

LanguageSettingsPrivateRemoveSpellcheckWordFunction::

@@ -426,8 +425,7 @@ LanguageSettingsPrivateRemoveSpellcheckWordFunction::Run() {

SpellcheckServiceFactory::GetForContext(browser_context());

bool success = service->GetCustomDictionary()->RemoveWord(params->word);

- return RespondNow(

- OneArgument(base::MakeUnique<base::FundamentalValue>(success)));

+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(success)));

}

LanguageSettingsPrivateGetTranslateTargetLanguageFunction::