Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc b/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
index 29a9791edc1292dfd2726fef8b5bf77c0d28dad2..f7663ed3f89eb67d3f80976686700de463232458 100644
--- a/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
+++ b/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
@@ -148,8 +148,7 @@ void InputImeAPI::OnExtensionLoaded(content::BrowserContext* browser_context,
// input.ime.activate API has been never called since loaded.
Profile* profile = Profile::FromBrowserContext(browser_context);
ExtensionPrefs::Get(profile)->UpdateExtensionPref(
- extension->id(), kPrefNeverActivatedSinceLoaded,
- new base::FundamentalValue(true));
+ extension->id(), kPrefNeverActivatedSinceLoaded, new base::Value(true));
}
void InputImeAPI::OnExtensionUnloaded(content::BrowserContext* browser_context,
@@ -161,7 +160,7 @@ void InputImeAPI::OnExtensionUnloaded(content::BrowserContext* browser_context,
// Records the extension is not the last active IME engine.
ExtensionPrefs::Get(Profile::FromBrowserContext(browser_context))
->UpdateExtensionPref(extension->id(), kPrefLastActiveEngine,
- new base::FundamentalValue(false));
+ new base::Value(false));
event_router->DeleteInputMethodEngine(extension->id());
}
}
@@ -189,7 +188,7 @@ void InputImeEventRouter::SetActiveEngine(const std::string& extension_id) {
// Records the extension is the last active IME engine.
ExtensionPrefs::Get(GetProfile())
->UpdateExtensionPref(extension_id, kPrefLastActiveEngine,
- new base::FundamentalValue(true));
+ new base::Value(true));
if (active_engine_) {
if (active_engine_->GetExtensionId() == extension_id) {
active_engine_->Enable(std::string());
@@ -199,8 +198,7 @@ void InputImeEventRouter::SetActiveEngine(const std::string& extension_id) {
// Records the extension is not the last active IME engine.
ExtensionPrefs::Get(GetProfile())
->UpdateExtensionPref(active_engine_->GetExtensionId(),
- kPrefLastActiveEngine,
- new base::FundamentalValue(false));
+ kPrefLastActiveEngine, new base::Value(false));
DeleteInputMethodEngine(active_engine_->GetExtensionId());
}
@@ -251,14 +249,12 @@ ExtensionFunction::ResponseAction InputImeActivateFunction::Run() {
// chrome. No need for user gesture checking.
event_router->SetActiveEngine(extension_id());
ExtensionPrefs::Get(profile)->UpdateExtensionPref(
- extension_id(), kPrefNeverActivatedSinceLoaded,
- new base::FundamentalValue(false));
+ extension_id(), kPrefNeverActivatedSinceLoaded, new base::Value(false));
return RespondNow(NoArguments());
}
// The API has already been called at least once.
ExtensionPrefs::Get(profile)->UpdateExtensionPref(
- extension_id(), kPrefNeverActivatedSinceLoaded,
- new base::FundamentalValue(false));
+ extension_id(), kPrefNeverActivatedSinceLoaded, new base::Value(false));
// Otherwise, this API is only allowed to be called from a user action.
if (!user_gesture())
@@ -319,8 +315,7 @@ void InputImeActivateFunction::OnPermissionBubbleFinished(
// Updates the extension preference if user checks the 'Never show this
// again' check box. So we can activate the extension directly next time.
ExtensionPrefs::Get(profile)->UpdateExtensionPref(
- extension_id(), kPrefWarningBubbleNeverShow,
- new base::FundamentalValue(true));
+ extension_id(), kPrefWarningBubbleNeverShow, new base::Value(true));
}
Respond(NoArguments());
@@ -378,7 +373,7 @@ ExtensionFunction::ResponseAction InputImeCreateWindowFunction::Run() {
return RespondNow(Error(error));
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
- result->Set("frameId", new base::FundamentalValue(frame_id));
+ result->Set("frameId", new base::Value(frame_id));
return RespondNow(OneArgument(std::move(result)));
}

Powered by Google App Engine
This is Rietveld 408576698