chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc ('k') | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

index e8798fd378a5511ea6bc679cf870818f14a37404..b990d137381971674fb96efa3d5debe356d349db 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

@@ -241,12 +241,12 @@ TEST_F(RulesRegistryWithCacheTest, DeclarativeRulesStored) {

// Default value is always true.

EXPECT_TRUE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));

- extension_prefs->UpdateExtensionPref(

- extension1_->id(), rules_stored_key, new base::FundamentalValue(false));

+ extension_prefs->UpdateExtensionPref(extension1_->id(), rules_stored_key,

+ new base::Value(false));

EXPECT_FALSE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));

- extension_prefs->UpdateExtensionPref(

- extension1_->id(), rules_stored_key, new base::FundamentalValue(true));

+ extension_prefs->UpdateExtensionPref(extension1_->id(), rules_stored_key,

+ new base::Value(true));

EXPECT_TRUE(cache_delegate->GetDeclarativeRulesStored(extension1_->id()));

// 2. Test writing behavior.

@@ -324,8 +324,8 @@ TEST_F(RulesRegistryWithCacheTest, RulesStoredFlagMultipleRegistries) {

EXPECT_TRUE(cache_delegate2->GetDeclarativeRulesStored(extension1_->id()));

// Update the flag for the first registry.

- extension_prefs->UpdateExtensionPref(

- extension1_->id(), rules_stored_key1, new base::FundamentalValue(false));

+ extension_prefs->UpdateExtensionPref(extension1_->id(), rules_stored_key1,

+ new base::Value(false));

EXPECT_FALSE(cache_delegate1->GetDeclarativeRulesStored(extension1_->id()));

EXPECT_TRUE(cache_delegate2->GetDeclarativeRulesStored(extension1_->id()));

}