chrome/browser/content_settings/content_settings_internal_extension_provider.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_internal_extension_provider.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_default_provider_unittest.cc ('k') | chrome/browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_internal_extension_provider.cc

diff --git a/chrome/browser/content_settings/content_settings_internal_extension_provider.cc b/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

index 239039fcb3651eae5a922a14a502e75772ee3364..d153e1012d5912ec3fbcde7bcf02d8bac9b99f35 100644

--- a/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

+++ b/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

@@ -211,11 +211,9 @@ void InternalExtensionProvider::SetContentSettingForExtensionAndResource(

CONTENT_SETTINGS_TYPE_PLUGINS,

resource);

} else {

- value_map_.SetValue(primary_pattern,

- secondary_pattern,

- CONTENT_SETTINGS_TYPE_PLUGINS,

- resource,

- new base::FundamentalValue(setting));

+ value_map_.SetValue(primary_pattern, secondary_pattern,

+ CONTENT_SETTINGS_TYPE_PLUGINS, resource,

+ new base::Value(setting));

}

NotifyObservers(primary_pattern,