Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: base/json/json_parser.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/json/json_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_parser.cc
diff --git a/base/json/json_parser.cc b/base/json/json_parser.cc
index 399d37b32fc2bbf55ead8875fec15983e1ae051d..1666c122b1caa3c03cd8e9b3988a5f4ee2496cbc 100644
--- a/base/json/json_parser.cc
+++ b/base/json/json_parser.cc
@@ -736,12 +736,12 @@ std::unique_ptr<Value> JSONParser::ConsumeNumber() {
int num_int;
if (StringToInt(num_string, &num_int))
- return base::MakeUnique<FundamentalValue>(num_int);
+ return base::MakeUnique<Value>(num_int);
double num_double;
if (StringToDouble(num_string.as_string(), &num_double) &&
std::isfinite(num_double)) {
- return base::MakeUnique<FundamentalValue>(num_double);
+ return base::MakeUnique<Value>(num_double);
}
return nullptr;
@@ -782,7 +782,7 @@ std::unique_ptr<Value> JSONParser::ConsumeLiteral() {
return nullptr;
}
NextNChars(kTrueLen - 1);
- return base::MakeUnique<FundamentalValue>(true);
+ return base::MakeUnique<Value>(true);
}
case 'f': {
const char kFalseLiteral[] = "false";
@@ -793,7 +793,7 @@ std::unique_ptr<Value> JSONParser::ConsumeLiteral() {
return nullptr;
}
NextNChars(kFalseLen - 1);
- return base::MakeUnique<FundamentalValue>(false);
+ return base::MakeUnique<Value>(false);
}
case 'n': {
const char kNullLiteral[] = "null";
« no previous file with comments | « no previous file | base/json/json_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698