Remove base::FundamentalValue

tools/clang/value_cleanup/ListValueRewriter.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ListValueRewriter.h"
 
 #include <assert.h>
 #include <algorithm>
 
 #include "clang/AST/ASTContext.h"
@@ skipping 333 matching lines @@
       append_double_callback_(replacements),
       append_string_callback_(replacements),
       append_released_unique_ptr_callback_(replacements),
       append_raw_ptr_callback_(replacements) {}
 
 void ListValueRewriter::RegisterMatchers(MatchFinder* match_finder) {
   auto is_list_append = cxxMemberCallExpr(
       callee(cxxMethodDecl(hasName("::base::ListValue::Append"))),
       argumentCountIs(1));
 
-  // base::ListValue::Append(new base::FundamentalValue(bool))
+  // base::ListValue::Append(new base::Value(bool))
   //     => base::ListValue::AppendBoolean()
   match_finder->addMatcher(
       id("callExpr",
          cxxMemberCallExpr(
              is_list_append,
              hasArgument(
-                 0, ignoringParenImpCasts(id(
-                        "newExpr",
-                        cxxNewExpr(has(cxxConstructExpr(
-                            hasDeclaration(cxxMethodDecl(hasName(
-                                "::base::FundamentalValue::FundamentalValue"))),
-                            argumentCountIs(1),
-                            hasArgument(
-                                0, id("argExpr",
-                                      expr(hasType(booleanType())))))))))))),
+                 0, ignoringParenImpCasts(
+                        id("newExpr",
+                           cxxNewExpr(has(cxxConstructExpr(
+                               hasDeclaration(cxxMethodDecl(
+                                   hasName("::base::Value::FundamentalValue"))),
+                               argumentCountIs(1),
+                               hasArgument(
+                                   0, id("argExpr",
+                                         expr(hasType(booleanType())))))))))))),
       &append_boolean_callback_);
 
-  // base::ListValue::Append(new base::FundamentalValue(int))
+  // base::ListValue::Append(new base::Value(int))
   //     => base::ListValue::AppendInteger()
   match_finder->addMatcher(
       id("callExpr",
          cxxMemberCallExpr(
              is_list_append,
              hasArgument(
                  0,
                  ignoringParenImpCasts(id(
                      "newExpr",
                      cxxNewExpr(has(cxxConstructExpr(
-                         hasDeclaration(cxxMethodDecl(hasName(
-                             "::base::FundamentalValue::FundamentalValue"))),
+                         hasDeclaration(cxxMethodDecl(
+                             hasName("::base::Value::FundamentalValue"))),
                          argumentCountIs(1),
                          hasArgument(0, id("argExpr",
                                            expr(hasType(isInteger()),
                                                 unless(hasType(
                                                     booleanType()))))))))))))),
       &append_integer_callback_);
 
-  // base::ListValue::Append(new base::FundamentalValue(double))
+  // base::ListValue::Append(new base::Value(double))
   //     => base::ListValue::AppendDouble()
   match_finder->addMatcher(
       id("callExpr",
          cxxMemberCallExpr(
              is_list_append,
              hasArgument(
                  0, ignoringParenImpCasts(id(
                         "newExpr",
                         cxxNewExpr(has(cxxConstructExpr(
-                            hasDeclaration(cxxMethodDecl(hasName(
-                                "::base::FundamentalValue::FundamentalValue"))),
+                            hasDeclaration(cxxMethodDecl(
+                                hasName("::base::Value::FundamentalValue"))),
                             argumentCountIs(1),
                             hasArgument(
                                 0, id("argExpr",
                                       expr(hasType(
                                           realFloatingPointType())))))))))))),
       &append_double_callback_);
 
   // base::ListValue::Append(new base::StringValue(...))
   //     => base::ListValue::AppendString()
   match_finder->addMatcher(
@@ skipping 59 matching lines @@
                           anyOf(hasInitializer(
                                     // Note this won't match C++11 uniform
                                     // initialization syntax, since the
                                     // CXXNewExpr is wrapped in an
                                     // InitListExpr in that case.
                                     ignoringParenImpCasts(cxxNewExpr())),
                                 unless(hasInitializer(expr()))),
                           unless(parmVarDecl()))))))))),
       &append_raw_ptr_callback_);
 }