Remove base::FundamentalValue

services/preferences/public/cpp/tests/pref_client_store_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/preferences/public/cpp/pref_client_store.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
@@ skipping 118 matching lines @@
 TEST_F(PrefClientStoreTest, Initialization) {
   std::set<std::string> keys;
   const std::string key("hey");
   keys.insert(key);
   store()->Subscribe(keys);
 
   EXPECT_FALSE(Initialized());
   EXPECT_FALSE(observer()->initialized);
 
   const int kValue = 42;
-  base::FundamentalValue pref(kValue);
+  base::Value pref(kValue);
   base::DictionaryValue prefs;
   prefs.Set(key, pref.CreateDeepCopy());
 
   // PreferenceManager notifies of PreferencesChanged, completing
   // initialization.
   OnPreferencesChanged(prefs);
   EXPECT_TRUE(Initialized());
   EXPECT_TRUE(observer()->initialized);
   EXPECT_TRUE(observer()->initialization_success);
   observer()->VerifyAndResetChangedKey(key);
 
   const base::Value* value = nullptr;
   int actual_value;
   EXPECT_TRUE(store()->GetValue(key, &value));
   EXPECT_NE(nullptr, value);
   EXPECT_TRUE(value->GetAsInteger(&actual_value));
   EXPECT_EQ(kValue, actual_value);
   EXPECT_FALSE(service()->set_preferences_called());
 }
 
 // Tests that values set silently are also set on the preference service, but
 // that no observers are notified.
 TEST_F(PrefClientStoreTest, SetValueSilently) {
   std::set<std::string> keys;
   const std::string key("hey");
   keys.insert(key);
   store()->Subscribe(keys);
 
   const int kValue = 42;
-  base::FundamentalValue pref(kValue);
+  base::Value pref(kValue);
   store()->SetValueSilently(key, pref.CreateDeepCopy(), 0);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(service()->set_preferences_called());
   EXPECT_TRUE(observer()->changed_keys.empty());
 }
 
 // Test that reporting values changed notifies observers, and the preference
 // service.
 TEST_F(PrefClientStoreTest, ReportValueChanged) {
   std::set<std::string> keys;
   const std::string key("hey");
   keys.insert(key);
   store()->Subscribe(keys);
 
   const int kValue = 42;
-  base::FundamentalValue pref(kValue);
+  base::Value pref(kValue);
   base::DictionaryValue prefs;
   prefs.Set(key, pref.CreateDeepCopy());
   OnPreferencesChanged(prefs);
   observer()->changed_keys.clear();
 
   store()->ReportValueChanged(key, 0);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(service()->set_preferences_called());
   observer()->VerifyAndResetChangedKey(key);
 }
 
 // Test that when initialized with multiple keys, that observers receive a
 // notification for each key.
 TEST_F(PrefClientStoreTest, MultipleKeyInitialization) {
   std::set<std::string> keys;
   const std::string key1("hey");
   const std::string key2("listen");
   keys.insert(key1);
   keys.insert(key2);
   store()->Subscribe(keys);
 
   EXPECT_FALSE(Initialized());
   EXPECT_FALSE(observer()->initialized);
 
   const int kValue = 42;
-  base::FundamentalValue pref1(kValue);
+  base::Value pref1(kValue);
   const std::string kStringValue("look");
   base::StringValue pref2(kStringValue);
 
   base::DictionaryValue prefs;
   prefs.Set(key1, pref1.CreateDeepCopy());
   prefs.Set(key2, pref2.CreateDeepCopy());
 
   // The observer should be notified of all keys set.
   OnPreferencesChanged(prefs);
   EXPECT_TRUE(Initialized());
@@ skipping 10 matching lines @@
 // Tests that if OnPreferencesChanged is received with invalid keys, that they
 // are ignored.
 TEST_F(PrefClientStoreTest, InvalidInitialization) {
   std::set<std::string> keys;
   const std::string key("hey");
   keys.insert(key);
   store()->Subscribe(keys);
 
   const std::string kInvalidKey("look");
   const int kValue = 42;
-  base::FundamentalValue pref(kValue);
+  base::Value pref(kValue);
   base::DictionaryValue prefs;
   prefs.Set(kInvalidKey, pref.CreateDeepCopy());
 
   OnPreferencesChanged(prefs);
   EXPECT_TRUE(observer()->changed_keys.empty());
 }
 
 // Tests that when tracking preferences which nest other DictionaryValues, that
 // modifications to the nested values properly notify the observer.
 TEST_F(PrefClientStoreTest, WriteToNestedPrefs) {
   std::set<std::string> keys;
   const std::string key1("hey");
   const std::string key2("listen");
   keys.insert(key1);
   keys.insert(key2);
   store()->Subscribe(keys);
 
   EXPECT_FALSE(Initialized());
   EXPECT_FALSE(observer()->initialized);
 
   const std::string sub_key1("look");
   const int kValue1 = 42;
-  base::FundamentalValue pref1(kValue1);
+  base::Value pref1(kValue1);
   base::DictionaryValue sub_dictionary1;
   sub_dictionary1.Set(sub_key1, pref1.CreateDeepCopy());
 
   const std::string sub_key2("Watch out!\n");
   const int kValue2 = 1337;
-  base::FundamentalValue pref2(kValue2);
+  base::Value pref2(kValue2);
   base::DictionaryValue sub_dictionary2;
   sub_dictionary2.Set(sub_key2, pref2.CreateDeepCopy());
 
   base::DictionaryValue prefs;
   prefs.Set(key1, sub_dictionary1.CreateDeepCopy());
   prefs.Set(key2, sub_dictionary2.CreateDeepCopy());
 
   // Initialize with the nested dictionaries
   OnPreferencesChanged(prefs);
   EXPECT_TRUE(Initialized());
@@ skipping 11 matching lines @@
   store()->GetMutableValue(key1, &result);
   EXPECT_EQ(base::Value::Type::DICTIONARY, result->GetType());
   EXPECT_TRUE(result->Equals(&sub_dictionary1));
 
   base::DictionaryValue* dictionary_result = nullptr;
   result->GetAsDictionary(&dictionary_result);
   EXPECT_NE(nullptr, dictionary_result);
 
   const std::string sub_key3("????");
   const int kValue3 = 9001;
-  base::FundamentalValue pref3(kValue3);
+  base::Value pref3(kValue3);
   dictionary_result->Set(sub_key3, pref3.CreateDeepCopy());
 
   observer()->changed_keys.clear();
   store()->ReportValueChanged(key1, 0);
   EXPECT_EQ(1u, observer()->changed_keys.size());
 }
 
 // Tests that when tracking preferences that nest other DictionaryValues, that
 // changes to the tracked keys properly notify the service and observer.
 TEST_F(PrefClientStoreTest, UpdateOuterNestedPrefs) {
   std::set<std::string> keys;
   const std::string key1("hey");
   const std::string key2("listen");
   keys.insert(key1);
   keys.insert(key2);
   store()->Subscribe(keys);
 
   EXPECT_FALSE(Initialized());
   EXPECT_FALSE(observer()->initialized);
 
   const std::string sub_key1("look");
   const int kValue1 = 42;
-  base::FundamentalValue pref1(kValue1);
+  base::Value pref1(kValue1);
   base::DictionaryValue sub_dictionary1;
   sub_dictionary1.Set(sub_key1, pref1.CreateDeepCopy());
 
   const std::string sub_key2("Watch out!\n");
   const int kValue2 = 1337;
-  base::FundamentalValue pref2(kValue2);
+  base::Value pref2(kValue2);
   base::DictionaryValue sub_dictionary2;
   sub_dictionary2.Set(sub_key2, pref2.CreateDeepCopy());
 
   base::DictionaryValue prefs;
   prefs.Set(key1, sub_dictionary1.CreateDeepCopy());
   prefs.Set(key2, sub_dictionary2.CreateDeepCopy());
 
   // Initialize with the nested dictionaries
   OnPreferencesChanged(prefs);
   EXPECT_TRUE(Initialized());
   EXPECT_TRUE(observer()->initialized);
   EXPECT_EQ(2u, observer()->changed_keys.size());
   EXPECT_NE(observer()->changed_keys.end(),
             std::find(observer()->changed_keys.begin(),
                       observer()->changed_keys.end(), key1));
   EXPECT_NE(observer()->changed_keys.end(),
             std::find(observer()->changed_keys.begin(),
                       observer()->changed_keys.end(), key2));
 
   observer()->changed_keys.clear();
   const int kValue3 = 9001;
-  base::FundamentalValue pref3(kValue3);
+  base::Value pref3(kValue3);
   store()->SetValue(key1, pref3.CreateDeepCopy(), 0);
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(1u, observer()->changed_keys.size());
   EXPECT_TRUE(service()->set_preferences_called());
 }
 
 // Tests that a PrefClientStore can subscribe multiple times to different
 // keys.
 TEST_F(PrefClientStoreTest, MultipleSubscriptions) {
   std::set<std::string> keys1;
@@ skipping 18 matching lines @@
 TEST_F(PrefClientStoreTest, MultipleObservers) {
   PrefStoreObserverMock observer2;
   store()->AddObserver(&observer2);
 
   std::set<std::string> keys;
   const std::string key("hey");
   keys.insert(key);
   store()->Subscribe(keys);
 
   const int kValue = 42;
-  base::FundamentalValue pref(kValue);
+  base::Value pref(kValue);
   base::DictionaryValue prefs;
   prefs.Set(key, pref.CreateDeepCopy());
 
   // PreferenceManager notifies of PreferencesChanged, completing
   // initialization.
   OnPreferencesChanged(prefs);
   EXPECT_TRUE(observer()->initialized);
   EXPECT_TRUE(observer2.initialized);
   EXPECT_TRUE(observer()->initialization_success);
   EXPECT_TRUE(observer2.initialization_success);
   observer()->VerifyAndResetChangedKey(key);
   observer2.VerifyAndResetChangedKey(key);
 
   store()->RemoveObserver(&observer2);
 }
 
 }  // namespace preferences