Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: headless/public/domains/types_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/argument_spec.cc ('k') | headless/public/internal/value_conversions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/json/json_reader.h" 5 #include "base/json/json_reader.h"
6 #include "base/json/json_string_value_serializer.h" 6 #include "base/json/json_string_value_serializer.h"
7 #include "headless/public/devtools/domains/accessibility.h" 7 #include "headless/public/devtools/domains/accessibility.h"
8 #include "headless/public/devtools/domains/dom.h" 8 #include "headless/public/devtools/domains/dom.h"
9 #include "headless/public/devtools/domains/memory.h" 9 #include "headless/public/devtools/domains/memory.h"
10 #include "headless/public/devtools/domains/page.h" 10 #include "headless/public/devtools/domains/page.h"
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 EXPECT_TRUE(object); 190 EXPECT_TRUE(object);
191 191
192 #if DCHECK_IS_ON() 192 #if DCHECK_IS_ON()
193 ErrorReporter errors; 193 ErrorReporter errors;
194 EXPECT_FALSE(runtime::EvaluateResult::Parse(*object, &errors)); 194 EXPECT_FALSE(runtime::EvaluateResult::Parse(*object, &errors));
195 EXPECT_TRUE(errors.HasErrors()); 195 EXPECT_TRUE(errors.HasErrors());
196 #endif // DCHECK_IS_ON() 196 #endif // DCHECK_IS_ON()
197 } 197 }
198 198
199 TEST(TypesTest, AnyProperty) { 199 TEST(TypesTest, AnyProperty) {
200 std::unique_ptr<base::Value> value(new base::FundamentalValue(123)); 200 std::unique_ptr<base::Value> value(new base::Value(123));
201 std::unique_ptr<accessibility::AXValue> object( 201 std::unique_ptr<accessibility::AXValue> object(
202 accessibility::AXValue::Builder() 202 accessibility::AXValue::Builder()
203 .SetType(accessibility::AXValueType::INTEGER) 203 .SetType(accessibility::AXValueType::INTEGER)
204 .SetValue(std::move(value)) 204 .SetValue(std::move(value))
205 .Build()); 205 .Build());
206 EXPECT_TRUE(object); 206 EXPECT_TRUE(object);
207 EXPECT_EQ(base::Value::Type::INTEGER, object->GetValue()->GetType()); 207 EXPECT_EQ(base::Value::Type::INTEGER, object->GetValue()->GetType());
208 208
209 std::unique_ptr<accessibility::AXValue> clone(object->Clone()); 209 std::unique_ptr<accessibility::AXValue> clone(object->Clone());
210 EXPECT_TRUE(clone); 210 EXPECT_TRUE(clone);
(...skipping 23 matching lines...) Expand all
234 ASSERT_NE(nullptr, clone); 234 ASSERT_NE(nullptr, clone);
235 235
236 std::string orig; 236 std::string orig;
237 JSONStringValueSerializer(&orig).Serialize(*params->Serialize()); 237 JSONStringValueSerializer(&orig).Serialize(*params->Serialize());
238 std::string clone_value; 238 std::string clone_value;
239 JSONStringValueSerializer(&clone_value).Serialize(*clone->Serialize()); 239 JSONStringValueSerializer(&clone_value).Serialize(*clone->Serialize());
240 EXPECT_EQ(orig, clone_value); 240 EXPECT_EQ(orig, clone_value);
241 } 241 }
242 242
243 } // namespace headless 243 } // namespace headless
OLDNEW
« no previous file with comments | « extensions/renderer/argument_spec.cc ('k') | headless/public/internal/value_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698