Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: content/browser/webui/web_ui_message_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | content/child/v8_value_converter_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/web_ui_message_handler.h" 5 #include "content/public/browser/web_ui_message_handler.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 if (value->GetString(0, &string16_value)) 70 if (value->GetString(0, &string16_value))
71 return string16_value; 71 return string16_value;
72 NOTREACHED(); 72 NOTREACHED();
73 return base::string16(); 73 return base::string16();
74 } 74 }
75 75
76 void WebUIMessageHandler::ResolveJavascriptCallback( 76 void WebUIMessageHandler::ResolveJavascriptCallback(
77 const base::Value& callback_id, 77 const base::Value& callback_id,
78 const base::Value& response) { 78 const base::Value& response) {
79 // cr.webUIResponse is a global JS function exposed from cr.js. 79 // cr.webUIResponse is a global JS function exposed from cr.js.
80 CallJavascriptFunction("cr.webUIResponse", callback_id, 80 CallJavascriptFunction("cr.webUIResponse", callback_id, base::Value(true),
81 base::FundamentalValue(true), response); 81 response);
82 } 82 }
83 83
84 void WebUIMessageHandler::RejectJavascriptCallback( 84 void WebUIMessageHandler::RejectJavascriptCallback(
85 const base::Value& callback_id, 85 const base::Value& callback_id,
86 const base::Value& response) { 86 const base::Value& response) {
87 // cr.webUIResponse is a global JS function exposed from cr.js. 87 // cr.webUIResponse is a global JS function exposed from cr.js.
88 CallJavascriptFunction("cr.webUIResponse", callback_id, 88 CallJavascriptFunction("cr.webUIResponse", callback_id, base::Value(false),
89 base::FundamentalValue(false), response); 89 response);
90 } 90 }
91 91
92 } // namespace content 92 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | content/child/v8_value_converter_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698