Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: content/browser/appcache/appcache_internals_ui.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/appcache/appcache_internals_ui.h" 5 #include "content/browser/appcache/appcache_internals_ui.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 *GetListValueFromAppCacheInfoCollection(collection.get())); 426 *GetListValueFromAppCacheInfoCollection(collection.get()));
427 } 427 }
428 428
429 void AppCacheInternalsUI::OnAppCacheInfoDeleted( 429 void AppCacheInternalsUI::OnAppCacheInfoDeleted(
430 const base::FilePath& partition_path, 430 const base::FilePath& partition_path,
431 const std::string& manifest_url, 431 const std::string& manifest_url,
432 bool deleted) { 432 bool deleted) {
433 web_ui()->CallJavascriptFunctionUnsafe( 433 web_ui()->CallJavascriptFunctionUnsafe(
434 kFunctionOnAppCacheInfoDeleted, 434 kFunctionOnAppCacheInfoDeleted,
435 base::StringValue(partition_path.AsUTF8Unsafe()), 435 base::StringValue(partition_path.AsUTF8Unsafe()),
436 base::StringValue(manifest_url), base::FundamentalValue(deleted)); 436 base::StringValue(manifest_url), base::Value(deleted));
437 } 437 }
438 438
439 void AppCacheInternalsUI::OnAppCacheDetailsReady( 439 void AppCacheInternalsUI::OnAppCacheDetailsReady(
440 const base::FilePath& partition_path, 440 const base::FilePath& partition_path,
441 const std::string& manifest_url, 441 const std::string& manifest_url,
442 std::unique_ptr<AppCacheResourceInfoVector> resource_info_vector) { 442 std::unique_ptr<AppCacheResourceInfoVector> resource_info_vector) {
443 if (resource_info_vector) { 443 if (resource_info_vector) {
444 web_ui()->CallJavascriptFunctionUnsafe( 444 web_ui()->CallJavascriptFunctionUnsafe(
445 kFunctionOnAppCacheDetailsReady, base::StringValue(manifest_url), 445 kFunctionOnAppCacheDetailsReady, base::StringValue(manifest_url),
446 base::StringValue(partition_path.AsUTF8Unsafe()), 446 base::StringValue(partition_path.AsUTF8Unsafe()),
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 *GetDictionaryValueForResponseEnquiry(response_enquiry), 489 *GetDictionaryValueForResponseEnquiry(response_enquiry),
490 base::StringValue(headers), base::StringValue(hex_dump)); 490 base::StringValue(headers), base::StringValue(hex_dump));
491 } 491 }
492 492
493 void AppCacheInternalsUI::OnFileDetailsFailed( 493 void AppCacheInternalsUI::OnFileDetailsFailed(
494 const Proxy::ResponseEnquiry& response_enquiry, 494 const Proxy::ResponseEnquiry& response_enquiry,
495 int net_result_code) { 495 int net_result_code) {
496 web_ui()->CallJavascriptFunctionUnsafe( 496 web_ui()->CallJavascriptFunctionUnsafe(
497 kFunctionOnFileDetailsFailed, 497 kFunctionOnFileDetailsFailed,
498 *GetDictionaryValueForResponseEnquiry(response_enquiry), 498 *GetDictionaryValueForResponseEnquiry(response_enquiry),
499 base::FundamentalValue(net_result_code)); 499 base::Value(net_result_code));
500 } 500 }
501 501
502 AppCacheInternalsUI::Proxy* AppCacheInternalsUI::GetProxyForPartitionPath( 502 AppCacheInternalsUI::Proxy* AppCacheInternalsUI::GetProxyForPartitionPath(
503 const base::FilePath& partition_path) { 503 const base::FilePath& partition_path) {
504 for (const scoped_refptr<Proxy>& proxy : appcache_proxies_) { 504 for (const scoped_refptr<Proxy>& proxy : appcache_proxies_) {
505 if (proxy->partition_path_ == partition_path) 505 if (proxy->partition_path_ == partition_path)
506 return proxy.get(); 506 return proxy.get();
507 } 507 }
508 NOTREACHED(); 508 NOTREACHED();
509 return nullptr; 509 return nullptr;
510 } 510 }
511 511
512 } // namespace content 512 } // namespace content
OLDNEW
« no previous file with comments | « components/user_prefs/tracked/segregated_pref_store_unittest.cc ('k') | content/browser/devtools/protocol_string.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698