Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: components/sync/syncable/entry_kernel.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/syncable/entry_kernel.h" 5 #include "components/sync/syncable/entry_kernel.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/json/string_escape.h" 9 #include "base/json/string_escape.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 } 126 }
127 127
128 base::StringValue* TimeToValue(const base::Time& t) { 128 base::StringValue* TimeToValue(const base::Time& t) {
129 return new base::StringValue(GetTimeDebugString(t)); 129 return new base::StringValue(GetTimeDebugString(t));
130 } 130 }
131 131
132 base::StringValue* IdToValue(const Id& id) { 132 base::StringValue* IdToValue(const Id& id) {
133 return id.ToValue(); 133 return id.ToValue();
134 } 134 }
135 135
136 base::FundamentalValue* BooleanToValue(bool bool_val) { 136 base::Value* BooleanToValue(bool bool_val) {
137 return new base::FundamentalValue(bool_val); 137 return new base::Value(bool_val);
138 } 138 }
139 139
140 base::StringValue* StringToValue(const std::string& str) { 140 base::StringValue* StringToValue(const std::string& str) {
141 return new base::StringValue(str); 141 return new base::StringValue(str);
142 } 142 }
143 143
144 base::StringValue* UniquePositionToValue(const UniquePosition& pos) { 144 base::StringValue* UniquePositionToValue(const UniquePosition& pos) {
145 return new base::StringValue(pos.ToDebugString()); 145 return new base::StringValue(pos.ToDebugString());
146 } 146 }
147 147
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 os << "TempFlags: "; 287 os << "TempFlags: ";
288 for (; i < BIT_TEMPS_END; ++i) { 288 for (; i < BIT_TEMPS_END; ++i) {
289 if (kernel->ref(static_cast<BitTemp>(i))) 289 if (kernel->ref(static_cast<BitTemp>(i)))
290 os << "#" << i - BIT_TEMPS_BEGIN << ", "; 290 os << "#" << i - BIT_TEMPS_BEGIN << ", ";
291 } 291 }
292 return os; 292 return os;
293 } 293 }
294 294
295 } // namespace syncable 295 } // namespace syncable
296 } // namespace syncer 296 } // namespace syncer
OLDNEW
« no previous file with comments | « components/sync/protocol/proto_value_conversions.cc ('k') | components/sync_preferences/pref_model_associator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698