Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: components/prefs/pref_change_registrar_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/bind_helpers.h" 6 #include "base/bind_helpers.h"
7 #include "components/prefs/pref_change_registrar.h" 7 #include "components/prefs/pref_change_registrar.h"
8 #include "components/prefs/pref_observer.h" 8 #include "components/prefs/pref_observer.h"
9 #include "components/prefs/pref_registry_simple.h" 9 #include "components/prefs/pref_registry_simple.h"
10 #include "components/prefs/testing_pref_service.h" 10 #include "components/prefs/testing_pref_service.h"
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 EXPECT_TRUE(pref_set->IsObserved(kHomePageIsNewTabPage)); 153 EXPECT_TRUE(pref_set->IsObserved(kHomePageIsNewTabPage));
154 EXPECT_FALSE(pref_set->IsObserved(kApplicationLocale)); 154 EXPECT_FALSE(pref_set->IsObserved(kApplicationLocale));
155 } 155 }
156 156
157 TEST_F(ObserveSetOfPreferencesTest, IsManaged) { 157 TEST_F(ObserveSetOfPreferencesTest, IsManaged) {
158 std::unique_ptr<PrefChangeRegistrar> pref_set(CreatePrefChangeRegistrar()); 158 std::unique_ptr<PrefChangeRegistrar> pref_set(CreatePrefChangeRegistrar());
159 EXPECT_FALSE(pref_set->IsManaged()); 159 EXPECT_FALSE(pref_set->IsManaged());
160 pref_service_->SetManagedPref(kHomePage, 160 pref_service_->SetManagedPref(kHomePage,
161 new StringValue("http://crbug.com")); 161 new StringValue("http://crbug.com"));
162 EXPECT_TRUE(pref_set->IsManaged()); 162 EXPECT_TRUE(pref_set->IsManaged());
163 pref_service_->SetManagedPref(kHomePageIsNewTabPage, 163 pref_service_->SetManagedPref(kHomePageIsNewTabPage, new Value(true));
164 new FundamentalValue(true));
165 EXPECT_TRUE(pref_set->IsManaged()); 164 EXPECT_TRUE(pref_set->IsManaged());
166 pref_service_->RemoveManagedPref(kHomePage); 165 pref_service_->RemoveManagedPref(kHomePage);
167 EXPECT_TRUE(pref_set->IsManaged()); 166 EXPECT_TRUE(pref_set->IsManaged());
168 pref_service_->RemoveManagedPref(kHomePageIsNewTabPage); 167 pref_service_->RemoveManagedPref(kHomePageIsNewTabPage);
169 EXPECT_FALSE(pref_set->IsManaged()); 168 EXPECT_FALSE(pref_set->IsManaged());
170 } 169 }
171 170
172 TEST_F(ObserveSetOfPreferencesTest, Observe) { 171 TEST_F(ObserveSetOfPreferencesTest, Observe) {
173 using testing::_; 172 using testing::_;
174 using testing::Mock; 173 using testing::Mock;
175 174
176 PrefChangeRegistrar pref_set; 175 PrefChangeRegistrar pref_set;
177 PrefChangeRegistrar::NamedChangeCallback callback = base::Bind( 176 PrefChangeRegistrar::NamedChangeCallback callback = base::Bind(
178 &ObserveSetOfPreferencesTest::OnPreferenceChanged, 177 &ObserveSetOfPreferencesTest::OnPreferenceChanged,
179 base::Unretained(this)); 178 base::Unretained(this));
180 pref_set.Init(pref_service_.get()); 179 pref_set.Init(pref_service_.get());
181 pref_set.Add(kHomePage, callback); 180 pref_set.Add(kHomePage, callback);
182 pref_set.Add(kHomePageIsNewTabPage, callback); 181 pref_set.Add(kHomePageIsNewTabPage, callback);
183 182
184 EXPECT_CALL(*this, OnPreferenceChanged(kHomePage)); 183 EXPECT_CALL(*this, OnPreferenceChanged(kHomePage));
185 pref_service_->SetUserPref(kHomePage, new StringValue("http://crbug.com")); 184 pref_service_->SetUserPref(kHomePage, new StringValue("http://crbug.com"));
186 Mock::VerifyAndClearExpectations(this); 185 Mock::VerifyAndClearExpectations(this);
187 186
188 EXPECT_CALL(*this, OnPreferenceChanged(kHomePageIsNewTabPage)); 187 EXPECT_CALL(*this, OnPreferenceChanged(kHomePageIsNewTabPage));
189 pref_service_->SetUserPref(kHomePageIsNewTabPage, 188 pref_service_->SetUserPref(kHomePageIsNewTabPage, new Value(true));
190 new FundamentalValue(true));
191 Mock::VerifyAndClearExpectations(this); 189 Mock::VerifyAndClearExpectations(this);
192 190
193 EXPECT_CALL(*this, OnPreferenceChanged(_)).Times(0); 191 EXPECT_CALL(*this, OnPreferenceChanged(_)).Times(0);
194 pref_service_->SetUserPref(kApplicationLocale, new StringValue("en_US.utf8")); 192 pref_service_->SetUserPref(kApplicationLocale, new StringValue("en_US.utf8"));
195 Mock::VerifyAndClearExpectations(this); 193 Mock::VerifyAndClearExpectations(this);
196 } 194 }
197 195
198 } // namespace base 196 } // namespace base
OLDNEW
« no previous file with comments | « components/prefs/overlay_user_pref_store_unittest.cc ('k') | components/prefs/pref_registry_simple.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698