Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: components/login/base_screen_handler_utils.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/login/base_screen_handler_utils.h" 5 #include "components/login/base_screen_handler_utils.h"
6 6
7 #include "components/signin/core/account_id/account_id.h" 7 #include "components/signin/core/account_id/account_id.h"
8 8
9 namespace login { 9 namespace login {
10 10
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 return false; 65 return false;
66 66
67 if (AccountId::Deserialize(serialized, out_value)) 67 if (AccountId::Deserialize(serialized, out_value))
68 return true; 68 return true;
69 69
70 LOG(ERROR) << "Failed to deserialize '" << serialized << "'"; 70 LOG(ERROR) << "Failed to deserialize '" << serialized << "'";
71 *out_value = AccountId::FromUserEmail(serialized); 71 *out_value = AccountId::FromUserEmail(serialized);
72 return true; 72 return true;
73 } 73 }
74 74
75 base::FundamentalValue MakeValue(bool v) { 75 base::Value MakeValue(bool v) {
76 return base::FundamentalValue(v); 76 return base::Value(v);
77 } 77 }
78 78
79 base::FundamentalValue MakeValue(int v) { 79 base::Value MakeValue(int v) {
80 return base::FundamentalValue(v); 80 return base::Value(v);
81 } 81 }
82 82
83 base::FundamentalValue MakeValue(double v) { 83 base::Value MakeValue(double v) {
84 return base::FundamentalValue(v); 84 return base::Value(v);
85 } 85 }
86 86
87 base::StringValue MakeValue(const std::string& v) { 87 base::StringValue MakeValue(const std::string& v) {
88 return base::StringValue(v); 88 return base::StringValue(v);
89 } 89 }
90 90
91 base::StringValue MakeValue(const base::string16& v) { 91 base::StringValue MakeValue(const base::string16& v) {
92 return base::StringValue(v); 92 return base::StringValue(v);
93 } 93 }
94 94
95 base::StringValue MakeValue(const AccountId& v) { 95 base::StringValue MakeValue(const AccountId& v) {
96 return base::StringValue(v.Serialize()); 96 return base::StringValue(v.Serialize());
97 } 97 }
98 98
99 ParsedValueContainer<AccountId>::ParsedValueContainer() { 99 ParsedValueContainer<AccountId>::ParsedValueContainer() {
100 } 100 }
101 101
102 } // namespace login 102 } // namespace login
OLDNEW
« no previous file with comments | « components/login/base_screen_handler_utils.h ('k') | components/login/screens/screen_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698