Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/password_manager_internals/password_manager_in ternals_ui.h" 5 #include "chrome/browser/ui/webui/password_manager_internals/password_manager_in ternals_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 9
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 // completed. 63 // completed.
64 UnregisterFromLoggingServiceIfNecessary(); 64 UnregisterFromLoggingServiceIfNecessary();
65 } 65 }
66 66
67 void PasswordManagerInternalsUI::DidStopLoading() { 67 void PasswordManagerInternalsUI::DidStopLoading() {
68 DCHECK(!registered_with_logging_service_); 68 DCHECK(!registered_with_logging_service_);
69 PasswordManagerInternalsService* service = 69 PasswordManagerInternalsService* service =
70 PasswordManagerInternalsServiceFactory::GetForBrowserContext( 70 PasswordManagerInternalsServiceFactory::GetForBrowserContext(
71 Profile::FromWebUI(web_ui())); 71 Profile::FromWebUI(web_ui()));
72 // No service means the WebUI is displayed in Incognito. 72 // No service means the WebUI is displayed in Incognito.
73 base::FundamentalValue is_incognito(!service); 73 base::Value is_incognito(!service);
74 web_ui()->CallJavascriptFunctionUnsafe("notifyAboutIncognito", is_incognito); 74 web_ui()->CallJavascriptFunctionUnsafe("notifyAboutIncognito", is_incognito);
75 75
76 if (service) { 76 if (service) {
77 registered_with_logging_service_ = true; 77 registered_with_logging_service_ = true;
78 78
79 std::string past_logs(service->RegisterReceiver(this)); 79 std::string past_logs(service->RegisterReceiver(this));
80 LogSavePasswordProgress(past_logs); 80 LogSavePasswordProgress(past_logs);
81 } 81 }
82 82
83 // Reset the first run experience for auto sign-in if the user opened 83 // Reset the first run experience for auto sign-in if the user opened
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 profile->GetPrefs()->SetBoolean( 121 profile->GetPrefs()->SetBoolean(
122 password_manager::prefs::kWasAutoSignInFirstRunExperienceShown, false); 122 password_manager::prefs::kWasAutoSignInFirstRunExperienceShown, false);
123 123
124 PasswordManagerInternalsService* service = 124 PasswordManagerInternalsService* service =
125 PasswordManagerInternalsServiceFactory::GetForBrowserContext( 125 PasswordManagerInternalsServiceFactory::GetForBrowserContext(
126 Profile::FromWebUI(web_ui())); 126 Profile::FromWebUI(web_ui()));
127 if (service) 127 if (service)
128 service->ProcessLog("Reset auto sign-in first run experience: yes"); 128 service->ProcessLog("Reset auto sign-in first run experience: yes");
129 } 129 }
130 } 130 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/options/reset_profile_settings_handler.cc ('k') | chrome/browser/ui/webui/policy_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698