Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ptr_util.h" 5 #include "base/memory/ptr_util.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "chrome/browser/policy/file_selection_dialogs_policy_handler.h" 7 #include "chrome/browser/policy/file_selection_dialogs_policy_handler.h"
8 #include "chrome/common/pref_names.h" 8 #include "chrome/common/pref_names.h"
9 #include "components/policy/core/common/policy_map.h" 9 #include "components/policy/core/common/policy_map.h"
10 #include "components/policy/core/common/policy_types.h" 10 #include "components/policy/core/common/policy_types.h"
(...skipping 13 matching lines...) Expand all
24 }; 24 };
25 25
26 TEST_F(FileSelectionDialogsPolicyTest, Default) { 26 TEST_F(FileSelectionDialogsPolicyTest, Default) {
27 handler_.ApplyPolicySettings(policy_, &prefs_); 27 handler_.ApplyPolicySettings(policy_, &prefs_);
28 EXPECT_FALSE(prefs_.GetValue(prefs::kPromptForDownload, NULL)); 28 EXPECT_FALSE(prefs_.GetValue(prefs::kPromptForDownload, NULL));
29 } 29 }
30 30
31 TEST_F(FileSelectionDialogsPolicyTest, EnableFileSelectionDialogs) { 31 TEST_F(FileSelectionDialogsPolicyTest, EnableFileSelectionDialogs) {
32 policy_.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY, 32 policy_.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY,
33 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 33 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
34 base::MakeUnique<base::FundamentalValue>(true), nullptr); 34 base::MakeUnique<base::Value>(true), nullptr);
35 handler_.ApplyPolicySettings(policy_, &prefs_); 35 handler_.ApplyPolicySettings(policy_, &prefs_);
36 36
37 // Allowing file-selection dialogs should not influence the PromptForDownload 37 // Allowing file-selection dialogs should not influence the PromptForDownload
38 // pref. 38 // pref.
39 EXPECT_FALSE(prefs_.GetValue(prefs::kPromptForDownload, NULL)); 39 EXPECT_FALSE(prefs_.GetValue(prefs::kPromptForDownload, NULL));
40 } 40 }
41 41
42 TEST_F(FileSelectionDialogsPolicyTest, DisableFileSelectionDialogs) { 42 TEST_F(FileSelectionDialogsPolicyTest, DisableFileSelectionDialogs) {
43 policy_.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY, 43 policy_.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY,
44 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD, 44 POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
45 base::MakeUnique<base::FundamentalValue>(false), nullptr); 45 base::MakeUnique<base::Value>(false), nullptr);
46 handler_.ApplyPolicySettings(policy_, &prefs_); 46 handler_.ApplyPolicySettings(policy_, &prefs_);
47 47
48 // Disabling file-selection dialogs should disable the PromptForDownload pref. 48 // Disabling file-selection dialogs should disable the PromptForDownload pref.
49 const base::Value* value = NULL; 49 const base::Value* value = NULL;
50 EXPECT_TRUE(prefs_.GetValue(prefs::kPromptForDownload, &value)); 50 EXPECT_TRUE(prefs_.GetValue(prefs::kPromptForDownload, &value));
51 ASSERT_TRUE(value); 51 ASSERT_TRUE(value);
52 bool prompt_for_download = true; 52 bool prompt_for_download = true;
53 bool result = value->GetAsBoolean(&prompt_for_download); 53 bool result = value->GetAsBoolean(&prompt_for_download);
54 EXPECT_TRUE(result); 54 EXPECT_TRUE(result);
55 EXPECT_FALSE(prompt_for_download); 55 EXPECT_FALSE(prompt_for_download);
56 } 56 }
57 57
58 } // namespace policy 58 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698