Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/net/disk_cache_dir_policy_handler.h" 9 #include "chrome/browser/net/disk_cache_dir_policy_handler.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
(...skipping 13 matching lines...) Expand all
24 }; 24 };
25 25
26 TEST_F(DiskCacheDirPolicyTest, Default) { 26 TEST_F(DiskCacheDirPolicyTest, Default) {
27 handler_.ApplyPolicySettings(policy_, &prefs_); 27 handler_.ApplyPolicySettings(policy_, &prefs_);
28 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL)); 28 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL));
29 } 29 }
30 30
31 TEST_F(DiskCacheDirPolicyTest, SetPolicyInvalid) { 31 TEST_F(DiskCacheDirPolicyTest, SetPolicyInvalid) {
32 // DiskCacheDir policy expects a string; give it a boolean. 32 // DiskCacheDir policy expects a string; give it a boolean.
33 policy_.Set(key::kDiskCacheDir, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, 33 policy_.Set(key::kDiskCacheDir, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
34 POLICY_SOURCE_CLOUD, 34 POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(false),
35 base::MakeUnique<base::FundamentalValue>(false), nullptr); 35 nullptr);
36 handler_.ApplyPolicySettings(policy_, &prefs_); 36 handler_.ApplyPolicySettings(policy_, &prefs_);
37 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL)); 37 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL));
38 } 38 }
39 39
40 TEST_F(DiskCacheDirPolicyTest, SetPolicyValid) { 40 TEST_F(DiskCacheDirPolicyTest, SetPolicyValid) {
41 // Use a variable in the value. It should be expanded by the handler. 41 // Use a variable in the value. It should be expanded by the handler.
42 const std::string in = "${user_name}/foo"; 42 const std::string in = "${user_name}/foo";
43 policy_.Set(key::kDiskCacheDir, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, 43 policy_.Set(key::kDiskCacheDir, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
44 POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(in), 44 POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(in),
45 nullptr); 45 nullptr);
46 handler_.ApplyPolicySettings(policy_, &prefs_); 46 handler_.ApplyPolicySettings(policy_, &prefs_);
47 47
48 const base::Value* value; 48 const base::Value* value;
49 ASSERT_TRUE(prefs_.GetValue(prefs::kDiskCacheDir, &value)); 49 ASSERT_TRUE(prefs_.GetValue(prefs::kDiskCacheDir, &value));
50 std::string out; 50 std::string out;
51 ASSERT_TRUE(value->GetAsString(&out)); 51 ASSERT_TRUE(value->GetAsString(&out));
52 EXPECT_NE(std::string::npos, out.find("foo")); 52 EXPECT_NE(std::string::npos, out.find("foo"));
53 EXPECT_EQ(std::string::npos, out.find("${user_name}")); 53 EXPECT_EQ(std::string::npos, out.find("${user_name}"));
54 } 54 }
55 55
56 } // namespace policy 56 } // namespace policy
OLDNEW
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc ('k') | chrome/browser/net/errorpage_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698