Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/terminal/terminal_private_api.h" 5 #include "chrome/browser/extensions/api/terminal/terminal_private_api.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 } 168 }
169 169
170 TerminalPrivateSendInputFunction::~TerminalPrivateSendInputFunction() {} 170 TerminalPrivateSendInputFunction::~TerminalPrivateSendInputFunction() {}
171 171
172 void TerminalPrivateOpenTerminalProcessFunction::RespondOnUIThread( 172 void TerminalPrivateOpenTerminalProcessFunction::RespondOnUIThread(
173 int terminal_id) { 173 int terminal_id) {
174 if (terminal_id < 0) { 174 if (terminal_id < 0) {
175 Respond(Error("Failed to open process.")); 175 Respond(Error("Failed to open process."));
176 return; 176 return;
177 } 177 }
178 Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(terminal_id))); 178 Respond(OneArgument(base::MakeUnique<base::Value>(terminal_id)));
179 } 179 }
180 180
181 ExtensionFunction::ResponseAction TerminalPrivateSendInputFunction::Run() { 181 ExtensionFunction::ResponseAction TerminalPrivateSendInputFunction::Run() {
182 std::unique_ptr<SendInput::Params> params(SendInput::Params::Create(*args_)); 182 std::unique_ptr<SendInput::Params> params(SendInput::Params::Create(*args_));
183 EXTENSION_FUNCTION_VALIDATE(params.get()); 183 EXTENSION_FUNCTION_VALIDATE(params.get());
184 184
185 // Registry lives on the FILE thread. 185 // Registry lives on the FILE thread.
186 content::BrowserThread::PostTask(content::BrowserThread::FILE, FROM_HERE, 186 content::BrowserThread::PostTask(content::BrowserThread::FILE, FROM_HERE,
187 base::Bind(&TerminalPrivateSendInputFunction::SendInputOnFileThread, 187 base::Bind(&TerminalPrivateSendInputFunction::SendInputOnFileThread,
188 this, params->pid, params->input)); 188 this, params->pid, params->input));
189 return RespondLater(); 189 return RespondLater();
190 } 190 }
191 191
192 void TerminalPrivateSendInputFunction::SendInputOnFileThread( 192 void TerminalPrivateSendInputFunction::SendInputOnFileThread(
193 int terminal_id, 193 int terminal_id,
194 const std::string& text) { 194 const std::string& text) {
195 bool success = 195 bool success =
196 chromeos::ProcessProxyRegistry::Get()->SendInput(terminal_id, text); 196 chromeos::ProcessProxyRegistry::Get()->SendInput(terminal_id, text);
197 197
198 content::BrowserThread::PostTask( 198 content::BrowserThread::PostTask(
199 content::BrowserThread::UI, FROM_HERE, 199 content::BrowserThread::UI, FROM_HERE,
200 base::Bind(&TerminalPrivateSendInputFunction::RespondOnUIThread, this, 200 base::Bind(&TerminalPrivateSendInputFunction::RespondOnUIThread, this,
201 success)); 201 success));
202 } 202 }
203 203
204 void TerminalPrivateSendInputFunction::RespondOnUIThread(bool success) { 204 void TerminalPrivateSendInputFunction::RespondOnUIThread(bool success) {
205 Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(success))); 205 Respond(OneArgument(base::MakeUnique<base::Value>(success)));
206 } 206 }
207 207
208 TerminalPrivateCloseTerminalProcessFunction:: 208 TerminalPrivateCloseTerminalProcessFunction::
209 ~TerminalPrivateCloseTerminalProcessFunction() {} 209 ~TerminalPrivateCloseTerminalProcessFunction() {}
210 210
211 ExtensionFunction::ResponseAction 211 ExtensionFunction::ResponseAction
212 TerminalPrivateCloseTerminalProcessFunction::Run() { 212 TerminalPrivateCloseTerminalProcessFunction::Run() {
213 std::unique_ptr<CloseTerminalProcess::Params> params( 213 std::unique_ptr<CloseTerminalProcess::Params> params(
214 CloseTerminalProcess::Params::Create(*args_)); 214 CloseTerminalProcess::Params::Create(*args_));
215 EXTENSION_FUNCTION_VALIDATE(params.get()); 215 EXTENSION_FUNCTION_VALIDATE(params.get());
(...skipping 13 matching lines...) Expand all
229 bool success = 229 bool success =
230 chromeos::ProcessProxyRegistry::Get()->CloseProcess(terminal_id); 230 chromeos::ProcessProxyRegistry::Get()->CloseProcess(terminal_id);
231 231
232 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE, 232 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
233 base::Bind(&TerminalPrivateCloseTerminalProcessFunction:: 233 base::Bind(&TerminalPrivateCloseTerminalProcessFunction::
234 RespondOnUIThread, this, success)); 234 RespondOnUIThread, this, success));
235 } 235 }
236 236
237 void TerminalPrivateCloseTerminalProcessFunction::RespondOnUIThread( 237 void TerminalPrivateCloseTerminalProcessFunction::RespondOnUIThread(
238 bool success) { 238 bool success) {
239 Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(success))); 239 Respond(OneArgument(base::MakeUnique<base::Value>(success)));
240 } 240 }
241 241
242 TerminalPrivateOnTerminalResizeFunction:: 242 TerminalPrivateOnTerminalResizeFunction::
243 ~TerminalPrivateOnTerminalResizeFunction() {} 243 ~TerminalPrivateOnTerminalResizeFunction() {}
244 244
245 ExtensionFunction::ResponseAction 245 ExtensionFunction::ResponseAction
246 TerminalPrivateOnTerminalResizeFunction::Run() { 246 TerminalPrivateOnTerminalResizeFunction::Run() {
247 std::unique_ptr<OnTerminalResize::Params> params( 247 std::unique_ptr<OnTerminalResize::Params> params(
248 OnTerminalResize::Params::Create(*args_)); 248 OnTerminalResize::Params::Create(*args_));
249 EXTENSION_FUNCTION_VALIDATE(params.get()); 249 EXTENSION_FUNCTION_VALIDATE(params.get());
(...skipping 12 matching lines...) Expand all
262 int height) { 262 int height) {
263 bool success = chromeos::ProcessProxyRegistry::Get()->OnTerminalResize( 263 bool success = chromeos::ProcessProxyRegistry::Get()->OnTerminalResize(
264 terminal_id, width, height); 264 terminal_id, width, height);
265 265
266 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE, 266 content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
267 base::Bind(&TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread, 267 base::Bind(&TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread,
268 this, success)); 268 this, success));
269 } 269 }
270 270
271 void TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread(bool success) { 271 void TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread(bool success) {
272 Respond(OneArgument(base::MakeUnique<base::FundamentalValue>(success))); 272 Respond(OneArgument(base::MakeUnique<base::Value>(success)));
273 } 273 }
274 274
275 TerminalPrivateAckOutputFunction::~TerminalPrivateAckOutputFunction() {} 275 TerminalPrivateAckOutputFunction::~TerminalPrivateAckOutputFunction() {}
276 276
277 ExtensionFunction::ResponseAction TerminalPrivateAckOutputFunction::Run() { 277 ExtensionFunction::ResponseAction TerminalPrivateAckOutputFunction::Run() {
278 std::unique_ptr<AckOutput::Params> params(AckOutput::Params::Create(*args_)); 278 std::unique_ptr<AckOutput::Params> params(AckOutput::Params::Create(*args_));
279 EXTENSION_FUNCTION_VALIDATE(params.get()); 279 EXTENSION_FUNCTION_VALIDATE(params.get());
280 280
281 content::WebContents* caller_contents = GetSenderWebContents(); 281 content::WebContents* caller_contents = GetSenderWebContents();
282 if (!caller_contents) 282 if (!caller_contents)
(...skipping 13 matching lines...) Expand all
296 params->pid)); 296 params->pid));
297 297
298 return RespondNow(NoArguments()); 298 return RespondNow(NoArguments());
299 } 299 }
300 300
301 void TerminalPrivateAckOutputFunction::AckOutputOnFileThread(int terminal_id) { 301 void TerminalPrivateAckOutputFunction::AckOutputOnFileThread(int terminal_id) {
302 chromeos::ProcessProxyRegistry::Get()->AckOutput(terminal_id); 302 chromeos::ProcessProxyRegistry::Get()->AckOutput(terminal_id);
303 } 303 }
304 304
305 } // namespace extensions 305 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698