Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: chrome/browser/extensions/api/settings_private/settings_private_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/settings_private/settings_private_api.h" 5 #include "chrome/browser/extensions/api/settings_private/settings_private_api.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 26 matching lines...) Expand all
37 37
38 SettingsPrivateDelegate* delegate = 38 SettingsPrivateDelegate* delegate =
39 SettingsPrivateDelegateFactory::GetForBrowserContext(browser_context()); 39 SettingsPrivateDelegateFactory::GetForBrowserContext(browser_context());
40 if (delegate == nullptr) 40 if (delegate == nullptr)
41 return RespondNow(Error(kDelegateIsNull)); 41 return RespondNow(Error(kDelegateIsNull));
42 42
43 PrefsUtil::SetPrefResult result = 43 PrefsUtil::SetPrefResult result =
44 delegate->SetPref(parameters->name, parameters->value.get()); 44 delegate->SetPref(parameters->name, parameters->value.get());
45 switch (result) { 45 switch (result) {
46 case PrefsUtil::SUCCESS: 46 case PrefsUtil::SUCCESS:
47 return RespondNow( 47 return RespondNow(OneArgument(base::MakeUnique<base::Value>(true)));
48 OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
49 case PrefsUtil::PREF_NOT_MODIFIABLE: 48 case PrefsUtil::PREF_NOT_MODIFIABLE:
50 // Not an error, but return false to indicate setting the pref failed. 49 // Not an error, but return false to indicate setting the pref failed.
51 return RespondNow( 50 return RespondNow(OneArgument(base::MakeUnique<base::Value>(false)));
52 OneArgument(base::MakeUnique<base::FundamentalValue>(false)));
53 case PrefsUtil::PREF_NOT_FOUND: 51 case PrefsUtil::PREF_NOT_FOUND:
54 return RespondNow(Error("Pref not found: *", parameters->name)); 52 return RespondNow(Error("Pref not found: *", parameters->name));
55 case PrefsUtil::PREF_TYPE_MISMATCH: 53 case PrefsUtil::PREF_TYPE_MISMATCH:
56 return RespondNow(Error("Incorrect type used for value of pref *", 54 return RespondNow(Error("Incorrect type used for value of pref *",
57 parameters->name)); 55 parameters->name));
58 case PrefsUtil::PREF_TYPE_UNSUPPORTED: 56 case PrefsUtil::PREF_TYPE_UNSUPPORTED:
59 return RespondNow(Error("Unsupported type used for value of pref *", 57 return RespondNow(Error("Unsupported type used for value of pref *",
60 parameters->name)); 58 parameters->name));
61 } 59 }
62 NOTREACHED(); 60 NOTREACHED();
63 return RespondNow( 61 return RespondNow(OneArgument(base::MakeUnique<base::Value>(false)));
64 OneArgument(base::MakeUnique<base::FundamentalValue>(false)));
65 } 62 }
66 63
67 //////////////////////////////////////////////////////////////////////////////// 64 ////////////////////////////////////////////////////////////////////////////////
68 // SettingsPrivateGetAllPrefsFunction 65 // SettingsPrivateGetAllPrefsFunction
69 //////////////////////////////////////////////////////////////////////////////// 66 ////////////////////////////////////////////////////////////////////////////////
70 67
71 SettingsPrivateGetAllPrefsFunction::~SettingsPrivateGetAllPrefsFunction() { 68 SettingsPrivateGetAllPrefsFunction::~SettingsPrivateGetAllPrefsFunction() {
72 } 69 }
73 70
74 ExtensionFunction::ResponseAction SettingsPrivateGetAllPrefsFunction::Run() { 71 ExtensionFunction::ResponseAction SettingsPrivateGetAllPrefsFunction::Run() {
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 std::unique_ptr<api::settings_private::SetDefaultZoom::Params> parameters = 134 std::unique_ptr<api::settings_private::SetDefaultZoom::Params> parameters =
138 api::settings_private::SetDefaultZoom::Params::Create(*args_); 135 api::settings_private::SetDefaultZoom::Params::Create(*args_);
139 EXTENSION_FUNCTION_VALIDATE(parameters.get()); 136 EXTENSION_FUNCTION_VALIDATE(parameters.get());
140 137
141 SettingsPrivateDelegate* delegate = 138 SettingsPrivateDelegate* delegate =
142 SettingsPrivateDelegateFactory::GetForBrowserContext(browser_context()); 139 SettingsPrivateDelegateFactory::GetForBrowserContext(browser_context());
143 if (delegate == nullptr) 140 if (delegate == nullptr)
144 return RespondNow(Error(kDelegateIsNull)); 141 return RespondNow(Error(kDelegateIsNull));
145 142
146 delegate->SetDefaultZoom(parameters->zoom); 143 delegate->SetDefaultZoom(parameters->zoom);
147 return RespondNow( 144 return RespondNow(OneArgument(base::MakeUnique<base::Value>(true)));
148 OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
149 } 145 }
150 146
151 } // namespace extensions 147 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698