Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AnalyserNode.h

Issue 2666063003: Continue to process AnalyserNode if inputs are silent. (Closed)
Patch Set: Add test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AnalyserNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AnalyserNode.h b/third_party/WebKit/Source/modules/webaudio/AnalyserNode.h
index 6c80967316f6ae626f740f60e3d65b1923d5e0e8..7e7a5f4886dec7e6e02e2e88fcd148f2260b79ea 100644
--- a/third_party/WebKit/Source/modules/webaudio/AnalyserNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/AnalyserNode.h
@@ -77,6 +77,12 @@ class AnalyserHandler final : public AudioBasicInspectorHandler {
private:
AnalyserHandler(AudioNode&, float sampleRate);
+ bool propagatesSilence() const {
+ // An AnalyserNode does actually propogate silence, but to get the
+ // time and FFT data updated correctly, process() needs to be
+ // called even if all the inputs are silent.
+ return false;
+ }
RealtimeAnalyser m_analyser;
};

Powered by Google App Engine
This is Rietveld 408576698