Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2666063002: VM: [Kernel] Revert changes to the native ports that introduced peers. (Closed)

Created:
3 years, 10 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 10 months ago
Reviewers:
erikcorry
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Revert changes to the native ports that introduced peers. The problem with these changes was that closed ports still continue to receive messages and as a result we start using dead peer objects. Fixing that would require more intrusive changes into message handler implementation - so instead we are reverting the changes and restoring manual PORT -> PEER mapping. BUG= R=erikcorry@google.com Committed: https://github.com/dart-lang/sdk/commit/9bae50bf47ad22ba9c6e2096fffd7fa4a2633ebb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -79 lines) Patch
M runtime/bin/io_service.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/bin/io_service_no_ssl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/bin/loader.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/loader.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/include/dart_native_api.h View 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 13 chunks +15 lines, -37 lines 0 comments Download
M runtime/vm/kernel_isolate.cc View 3 chunks +54 lines, -6 lines 0 comments Download
M runtime/vm/native_api_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/native_message_handler.h View 2 chunks +1 line, -5 lines 0 comments Download
M runtime/vm/native_message_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M samples/sample_extension/sample_extension.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Vyacheslav Egorov (Google)
PTAL
3 years, 10 months ago (2017-01-31 09:12:29 UTC) #3
erikcorry
lgtm
3 years, 10 months ago (2017-01-31 09:23:48 UTC) #4
Vyacheslav Egorov (Google)
3 years, 10 months ago (2017-01-31 09:30:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9bae50bf47ad22ba9c6e2096fffd7fa4a2633ebb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698