Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart

Issue 2666053004: Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html util library. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart b/pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
index b5a1064554f66a1a3824700981c4e94a0a5cf06b..3cab3802cc09c358825f56c1437389af77933e79 100644
--- a/pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
+++ b/pkg/dev_compiler/tool/input_sdk/lib/html/html_common/conversions_dart2js.dart
@@ -60,11 +60,11 @@ class _StructuredCloneDart2Js extends _StructuredClone {
class _AcceptStructuredCloneDart2Js extends _AcceptStructuredClone {
- newJsList(length) => JS('JSExtendableArray', 'new Array(#)', length);
- newDartList(length) => newJsList(length);
- identicalInJs(a, b) => identical(a, b);
+ List newJsList(length) => JS('JSExtendableArray', 'new Array(#)', length);
+ List newDartList(length) => newJsList(length);
+ bool identicalInJs(a, b) => identical(a, b);
- void forEachJsField(object, action) {
+ void forEachJsField(object, action(key, value)) {
for (final key in JS('JSExtendableArray', 'Object.keys(#)', object)) {
action(key, JS('var', '#[#]', object, key));
vsm 2017/02/01 18:37:13 Did this change anything? action may still be a d
Jacob 2017/02/01 20:33:48 action is not a dcall because its signature is (d
}

Powered by Google App Engine
This is Rietveld 408576698