Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: pkg/dev_compiler/lib/js/legacy/dart_sdk.js

Side-by-side diff isn't available for this file because of its large size.
Issue 2666053004: Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html util library. (Closed)
Patch Set: Remove dynamic call from _LinkedHashSet. Remove some dcalls from the dart:html util library. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/js/es6/dart_sdk.js ('k') | pkg/dev_compiler/lib/sdk/ddc_sdk.sum » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/js/legacy/dart_sdk.js
diff --git a/pkg/dev_compiler/lib/js/legacy/dart_sdk.js b/pkg/dev_compiler/lib/js/legacy/dart_sdk.js
index 222f6226cca83c0f9b9f53950c6f67bc47bd923c..cf5ca5dd0360f5148c5deb9103e1903cda459444 100644
--- a/pkg/dev_compiler/lib/js/legacy/dart_sdk.js
+++ b/pkg/dev_compiler/lib/js/legacy/dart_sdk.js
@@ -25728,13 +25728,13 @@ dart_library.library('dart_sdk', null, /* Imports */[
this[_modifications$] = modifications;
this[_cell$] = null;
this[_current$2] = null;
- this[_cell$] = collection._LinkedHashSetCell._check(dart.dload(this[_set], _first$));
+ this[_cell$] = this[_set][_first$];
}
get current() {
return this[_current$2];
}
moveNext() {
- if (!dart.equals(this[_modifications$], dart.dload(this[_set], _modifications$))) {
+ if (this[_modifications$] != this[_set][_modifications$]) {
dart.throw(new core.ConcurrentModificationError(this[_set]));
} else if (this[_cell$] == null) {
this[_current$2] = null;
@@ -25749,9 +25749,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
dart.addTypeTests(_LinkedHashSetIterator);
_LinkedHashSetIterator[dart.implements] = () => [IteratorOfE()];
dart.setSignature(_LinkedHashSetIterator, {
- constructors: () => ({new: dart.definiteFunctionType(collection._LinkedHashSetIterator$(E), [dart.dynamic, core.int])}),
+ constructors: () => ({new: dart.definiteFunctionType(collection._LinkedHashSetIterator$(E), [collection._LinkedHashSet, core.int])}),
fields: () => ({
- [_set]: dart.dynamic,
+ [_set]: collection._LinkedHashSet,
[_modifications$]: core.int,
[_cell$]: collection._LinkedHashSetCell,
[_current$2]: E
@@ -99196,7 +99196,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
let copy = this.newJsList(length);
this.writeSlot(slot, copy);
for (; i < dart.notNull(length); i++) {
- dart.dsetindex(copy, i, this.walk(e[dartx._get](i)));
+ copy[dartx._set](i, this.walk(e[dartx._get](i)));
}
return copy;
}
@@ -99217,7 +99217,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
writeSlot: dart.definiteFunctionType(dart.dynamic, [core.int, dart.dynamic]),
cleanupSlots: dart.definiteFunctionType(dart.dynamic, []),
walk: dart.definiteFunctionType(dart.dynamic, [dart.dynamic]),
- copyList: dart.definiteFunctionType(dart.dynamic, [core.List, core.int]),
+ copyList: dart.definiteFunctionType(core.List, [core.List, core.int]),
convertDartToNative_PrepareForStructuredClone: dart.definiteFunctionType(dart.dynamic, [dart.dynamic])
})
});
@@ -99266,14 +99266,15 @@ dart_library.library('dart_sdk', null, /* Imports */[
return copy;
}
if (dart.test(html_common.isJavaScriptArray(e))) {
- let slot = this.findSlot(e);
+ let l = e;
+ let slot = this.findSlot(l);
let copy = this.readSlot(slot);
if (copy != null) return copy;
- let length = core.int._check(dart.dload(e, 'length'));
- copy = dart.test(this.mustCopy) ? this.newDartList(length) : e;
+ let length = l[dartx.length];
+ copy = dart.test(this.mustCopy) ? this.newDartList(length) : l;
this.writeSlot(slot, copy);
for (let i = 0; i < dart.notNull(length); i++) {
- dart.dsetindex(copy, i, this.walk(dart.dindex(e, i)));
+ copy[dartx._set](i, this.walk(l[dartx._get](i)));
}
return copy;
}
@@ -99434,7 +99435,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
methods: () => ({
newJsMap: dart.definiteFunctionType(dart.dynamic, []),
putIntoMap: dart.definiteFunctionType(dart.void, [dart.dynamic, dart.dynamic, dart.dynamic]),
- newJsList: dart.definiteFunctionType(dart.dynamic, [dart.dynamic]),
+ newJsList: dart.definiteFunctionType(core.List, [dart.dynamic]),
cloneNotRequired: dart.definiteFunctionType(core.bool, [dart.dynamic])
})
});
@@ -99459,10 +99460,10 @@ dart_library.library('dart_sdk', null, /* Imports */[
};
dart.setSignature(html_common._AcceptStructuredCloneDart2Js, {
methods: () => ({
- newJsList: dart.definiteFunctionType(dart.dynamic, [dart.dynamic]),
- newDartList: dart.definiteFunctionType(dart.dynamic, [dart.dynamic]),
+ newJsList: dart.definiteFunctionType(core.List, [dart.dynamic]),
+ newDartList: dart.definiteFunctionType(core.List, [dart.dynamic]),
identicalInJs: dart.definiteFunctionType(core.bool, [dart.dynamic, dart.dynamic]),
- forEachJsField: dart.definiteFunctionType(dart.void, [dart.dynamic, dart.dynamic])
+ forEachJsField: dart.definiteFunctionType(dart.void, [dart.dynamic, dynamicAnddynamicTodynamic()])
})
});
html_common.isJavaScriptDate = function(value) {
« no previous file with comments | « pkg/dev_compiler/lib/js/es6/dart_sdk.js ('k') | pkg/dev_compiler/lib/sdk/ddc_sdk.sum » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698