Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7030)

Unified Diff: chrome/browser/resources/md_bookmarks/list.html

Issue 2666033002: [MD Bookmarks] Add edit folder. (Closed)
Patch Set: Test with mockinteractions in list test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/bookmarks_strings.grdp ('k') | chrome/browser/resources/md_bookmarks/list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_bookmarks/list.html
diff --git a/chrome/browser/resources/md_bookmarks/list.html b/chrome/browser/resources/md_bookmarks/list.html
index ca9437981bbf336b71b11e43631f9762abd6f80a..a9f4a57719fcfc181511ce37cf17ff9924ce46dc 100644
--- a/chrome/browser/resources/md_bookmarks/list.html
+++ b/chrome/browser/resources/md_bookmarks/list.html
@@ -37,9 +37,10 @@
</style>
<dialog is="cr-action-menu" id="dropdown">
<button class="dropdown-item" on-tap="onEditTap_">
- $i18n{menuEdit}
+ [[getEditActionLabel_(menuItem_)]]
</button>
- <button class="dropdown-item" on-tap="onCopyURLTap_">
+ <button class="dropdown-item" on-tap="onCopyURLTap_"
+ hidden$="[[!menuItem_.url]]">
$i18n{menuCopyURL}
</button>
<button class="dropdown-item" on-tap="onDeleteTap_">
@@ -47,7 +48,7 @@
</button>
</dialog>
<dialog is="cr-dialog" id="editBookmark">
- <div class="title">$i18n{editBookmarkTitle}</div>
+ <div class="title">[[getEditorTitle_(menuItem_)]]</div>
<div class="body">
<paper-input always-float-label id="name"
label="$i18n{editDialogNameInput}"
@@ -55,14 +56,16 @@
</paper-input>
<paper-input always-float-label id="url"
label="$i18n{editDialogUrlInput}"
- value="{{menuItem_.url}}">
+ value="{{menuItem_.url}}"
+ hidden$="[[!menuItem_.url]]">
</paper-input>
</div>
<div class="button-container">
<paper-button class="cancel-button" on-tap="onCancelEditTap_">
$i18n{cancelEdit}
</paper-button>
- <paper-button class="action-button" on-tap="onSaveEditTap_">
+ <paper-button class="action-button" on-tap="onSaveEditTap_"
+ id='saveButton'>
$i18n{saveEdit}
</paper-button>
</div>
« no previous file with comments | « chrome/app/bookmarks_strings.grdp ('k') | chrome/browser/resources/md_bookmarks/list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698