Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5785)

Unified Diff: chrome/browser/resources/md_bookmarks/list.js

Issue 2666033002: [MD Bookmarks] Add edit folder. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/list.js
diff --git a/chrome/browser/resources/md_bookmarks/list.js b/chrome/browser/resources/md_bookmarks/list.js
index 018b9c6d6114c0a618318ee5477fce73d9a6634b..4f9151060c938f0a77eda7682219d6431fbb60d1 100644
--- a/chrome/browser/resources/md_bookmarks/list.js
+++ b/chrome/browser/resources/md_bookmarks/list.js
@@ -13,6 +13,8 @@ Polymer({
displayedList: Array,
searchTerm: String,
+
+ hideUrlInput_: Boolean,
},
listeners: {
@@ -34,8 +36,8 @@ Polymer({
/** @private */
onEditTap_: function() {
this.closeDropdownMenu_();
- if (this.menuItem_.url)
- this.$.editBookmark.showModal();
+ this.hideUrlInput_ = !this.menuItem_.url;
+ this.$.editBookmark.showModal();
},
/** @private */
@@ -83,6 +85,12 @@ Polymer({
},
/** @private */
+ getEditorTitle_: function() {
+ var title = this.menuItem_.url ? 'editBookmarkTitle' : 'editFolderTitle';
+ return this.loadTimeData.getString(title);
+ },
jiaxi 2017/02/01 00:31:23 Hmm... I'm a bit confused here. Where is this func
angelayang 2017/02/01 02:47:34 Oops yes sorry i forgot to commit where i did use
+
+ /** @private */
emptyListMessage_: function() {
var emptyListMessage = this.searchTerm ? 'noSearchResults' : 'emptyList';
return loadTimeData.getString(emptyListMessage);

Powered by Google App Engine
This is Rietveld 408576698