Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: lib/src/resolve.dart

Issue 2666013004: Address a number of open issues. (Closed)
Patch Set: Swap imports in resource_loader.dart. Addresses #16. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/io_io.dart ('k') | lib/src/resource_loader.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import "dart:async" show Future; 5 import "dart:async" show Future;
6 import "dart:isolate" show Isolate; 6 import "dart:isolate" show Isolate;
7 7
8 /// Helper function for resolving to a non-relative, non-package URI. 8 /// Helper function for resolving to a non-relative, non-package URI.
9 Future<Uri> resolveUri(Uri uri) async { 9 Future<Uri> resolveUri(Uri uri) {
10 if (uri.scheme == "package") { 10 if (uri.scheme == "package") {
11 return Isolate.resolvePackageUri(uri); 11 return Isolate.resolvePackageUri(uri).then((resolvedUri) =>
12 resolvedUri ?? new ArgumentError.value(uri, "uri", "Unknown package"));
floitsch 2017/02/01 12:17:59 That looks wrong. I'm guessing you wanted to throw
Lasse Reichstein Nielsen 2017/02/01 12:44:36 True, should have had a throw. Rewriting to the fu
12 } 13 }
13 return Uri.base.resolveUri(uri); 14 return new Future<Uri>.value(Uri.base.resolveUri(uri));
14 } 15 }
OLDNEW
« no previous file with comments | « lib/src/io_io.dart ('k') | lib/src/resource_loader.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698