Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html

Issue 2666013002: DevTools: render console filter in the main console toolbar. (Closed)
Patch Set: Introduce progress monitor Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html b/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
index 5765551c6947a83ae5a6a7ebe6a387f560702c0e..73ea7ca1f72256f5f94311567d88e7432dcfc3a9 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
@@ -7,7 +7,7 @@ console.log("message from page!");
function test()
{
- var checkbox = Console.ConsoleView.instance()._showAllMessagesCheckbox.inputElement;
+ var checkbox = Console.ConsoleView.instance()._filter._showTargetMessagesCheckbox.inputElement;
//we can't use usual InspectorTest.dumpConsoleMessages(), because it dumps url of message and it flakes in case of iframe
function dumpVisibleConsoleMessageText()
@@ -22,8 +22,8 @@ function test()
function testInitialState(next)
{
- if (!checkbox.checked)
- InspectorTest.addResult("\"Show all messages\" checkbox should be checked by default");
+ if (checkbox.checked)
+ InspectorTest.addResult("\"Show target messages\" checkbox should be unchecked by default");
dumpVisibleConsoleMessageText();
next();
},
@@ -57,7 +57,7 @@ function test()
<body>
<p>
-Tests that console shows messages only from specific context when show all checkbox is unchecked.</a>
+Tests that console shows messages only from specific context when show target checkbox is checked.</a>
</p>
<iframe name="myIFrame" src="resources/console-show-all-messages-iframe.html" onload="runTest()"></iframe>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698