third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html - Issue 2666013002: DevTools: render console filter in the main console toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html

Issue 2666013002: DevTools: render console filter in the main console toolbar. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html b/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html

index 5765551c6947a83ae5a6a7ebe6a387f560702c0e..5df3c50949c53ae2408611aa3657d8544a33a170 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html

@@ -7,7 +7,7 @@ console.log("message from page!");

function test()

{

- var checkbox = Console.ConsoleView.instance()._showAllMessagesCheckbox.inputElement;

+ var checkbox = Console.ConsoleView.instance()._filter._showTargetMessagesCheckbox.inputElement;

//we can't use usual InspectorTest.dumpConsoleMessages(), because it dumps url of message and it flakes in case of iframe

function dumpVisibleConsoleMessageText()

@@ -22,8 +22,8 @@ function test()

function testInitialState(next)

{

- if (!checkbox.checked)

- InspectorTest.addResult("\"Show all messages\" checkbox should be checked by default");

+ if (checkbox.checked)

+ InspectorTest.addResult("\"Show all messages\" checkbox should be unchecked by default");

dgozman 2017/01/31 04:21:29 Show all messages -> Show target messages

dumpVisibleConsoleMessageText();

next();

@@ -57,7 +57,7 @@ function test()

<body>

<p>

-Tests that console shows messages only from specific context when show all checkbox is unchecked.</a>

+Tests that console shows messages only from specific context when show target checkbox is checked.</a>

</p>