DevTools: render console filter in the main console toolbar.

third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 535 matching lines @@
   MouseUp: Symbol('MouseUp')
 };
 
 /**
  * @unrestricted
  */
 UI.ToolbarInput = class extends UI.ToolbarItem {
   /**
    * @param {string=} placeholder
    * @param {number=} growFactor
+   * @param {number=} shrinkFactor
    */
-  constructor(placeholder, growFactor) {
+  constructor(placeholder, growFactor, shrinkFactor) {
     super(createElementWithClass('input', 'toolbar-item'));
     this.element.addEventListener('input', this._onChangeCallback.bind(this), false);
     if (growFactor)
       this.element.style.flexGrow = growFactor;
+    if (shrinkFactor)
+      this.element.style.flexShrink = shrinkFactor;
     if (placeholder)
       this.element.setAttribute('placeholder', placeholder);
     this._value = '';
   }
 
   /**
    * @param {string} value
    */
   setValue(value) {
     this._value = value;
@@ skipping 316 matching lines @@
    * @param {number} width
    */
   setMaxWidth(width) {
     this._selectElement.style.maxWidth = width + 'px';
   }
 };
 
 /**
  * @unrestricted
  */
+UI.ToolbarSettingComboBox = class extends UI.ToolbarComboBox {
+  /**
+   * @param {!Array.<!{value: string, label: string, title: string, default:(boolean|undefined)}>} options
+   * @param {!Common.Setting} setting
+   * @param {string=} optGroup
+   */
+  constructor(options, setting, optGroup) {
+    super(null);
+    this._setting = setting;
+    this._options = options;
+    this._selectElement.addEventListener('change', this._filterChanged.bind(this), false);
+    var optGroupElement = optGroup ? this._selectElement.createChild('optgroup') : null;
+    if (optGroupElement)
+      optGroupElement.label = optGroup;
+    for (var i = 0; i < options.length; ++i) {
+      var filterOption = options[i];

[dgozman, 2017/01/31 04:21:30]

It's not a filter anymore.

[pfeldman, 2017/01/31 19:54:44]

Done.

+      var option = this.createOption(filterOption.label, filterOption.title, filterOption.value);
+      if (optGroupElement)
+        optGroupElement.appendChild(option);
+      else
+        this._selectElement.appendChild(option);

[dgozman, 2017/01/31 04:21:30]

You can assign this._selectElement to optGroupElement before for-loop to
simplify this.

[pfeldman, 2017/01/31 19:54:44]

I fixed it, but I did not reassign anything.

+      if (setting.get() === filterOption.value)
+        this.setSelectedIndex(i);
+    }
+
+    setting.addChangeListener(this._settingChanged, this);
+  }
+
+  /**
+   * @return {boolean}
+   */
+  isActive() {

[dgozman, 2017/01/31 04:21:30]

isNonDefault

[pfeldman, 2017/01/31 19:54:44]

Done in a way.

+    var option = this._options[this.selectedIndex()];
+    return !option || !option.default;
+  }
+
+  /**
+   * @return {string}
+   */
+  value() {
+    return this._options[this.selectedIndex()].value;
+  }
+
+  _settingChanged() {
+    if (this._muteSettingListener)
+      return;
+
+    var value = this._setting.get();
+    for (var i = 0; i < this._options.length; ++i) {
+      if (value === this._options[i].value) {
+        this.setSelectedIndex(i);
+        break;
+      }
+    }
+  }
+
+  /**
+   * @param {!Event} event
+   */
+  _filterChanged(event) {

[dgozman, 2017/01/31 04:21:29]

_valueChanged

[pfeldman, 2017/01/31 19:54:45]

Done.

+    var option = this._options[this.selectedIndex()];
+    this._muteSettingListener = true;
+    this._setting.set(option.value);
+    this._muteSettingListener = false;
+  }
+};
+
+/**
+ * @unrestricted
+ */
 UI.ToolbarCheckbox = class extends UI.ToolbarItem {
   /**
    * @param {string} text
    * @param {string=} title
    * @param {!Common.Setting=} setting
    * @param {function()=} listener
    */
   constructor(text, title, setting, listener) {
     super(UI.createCheckboxLabel(text));
     this.element.classList.add('checkbox');
@@ skipping 22 matching lines @@
 
   /**
    * @override
    * @param {boolean} enabled
    */
   _applyEnabledState(enabled) {
     super._applyEnabledState(enabled);
     this.inputElement.disabled = !enabled;
   }
 };