Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2666003005: Include characterHex in all encoding errors. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, Johnni Winther, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
ahe
This should take of dart2js hostchecked failures on the build bot.
3 years, 10 months ago (2017-02-01 15:41:21 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-01 16:49:56 UTC) #5
ahe
3 years, 10 months ago (2017-02-01 16:53:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c6f67f76fce08fb092534591ab72f74b2cd7678a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698