chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java - Issue 2665983005: Ntp: use callbacks for partial binding, they can carry more detail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java

Issue 2665983005: Ntp: use callbacks for partial binding, they can carry more detail. (Closed)

Patch Set: Address review comments from bauerb. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java

index b9fb3c32f26818220e1fbdf78bbe39f389874835..9bbc0f3a255be61c2228ce1fa8e8c440213ccaa7 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java

@@ -25,6 +25,7 @@ import org.mockito.Mock;

import org.mockito.MockitoAnnotations;

import org.robolectric.annotation.Config;

+import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder.PartialBindCallback;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import org.chromium.testing.local.LocalRobolectricTestRunner;

@@ -217,7 +218,8 @@ public class InnerNodeTest {

}

@Override

- public void onItemRangeChanged(TreeNode child, int index, int count, Object payload) {

+ public void onItemRangeChanged(

+ TreeNode child, int index, int count, PartialBindCallback callback) {

checkCount(child);

}