Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3181)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java

Issue 2665983005: Ntp: use callbacks for partial binding, they can carry more detail. (Closed)
Patch Set: Address review comments from bauerb. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java
index 963e28c82015b4144cded4ed8bd6a93587fc5403..f23e68af99db71ffc173d34572c3288df0cb5b5b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeParent.java
@@ -4,6 +4,10 @@
package org.chromium.chrome.browser.ntp.cards;
+import android.support.annotation.Nullable;
+
+import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder.PartialBindCallback;
+
/**
* Interface to allow propagating change events upwards in the tree.
*/
@@ -15,10 +19,11 @@ public interface NodeParent {
* @param index The starting position of the range of changed items, relative to the
* {@code child}.
* @param count The number of changed items.
- * @param payload Optional parameter, use {@code null} to identify a "full" update.
+ * @param callback Optional parameter, use {@code null} to identify a "full" update.
* @see android.support.v7.widget.RecyclerView.Adapter#notifyItemRangeChanged(int, int, Object)
*/
- void onItemRangeChanged(TreeNode child, int index, int count, Object payload);
+ void onItemRangeChanged(
+ TreeNode child, int index, int count, @Nullable PartialBindCallback callback);
/**
* Notifies that {@code count} items starting at position {@code index} under the {@code child}

Powered by Google App Engine
This is Rietveld 408576698