Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3382)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

Issue 2665983005: Ntp: use callbacks for partial binding, they can carry more detail. (Closed)
Patch Set: Address review comments from bauerb. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
index 93df5b6de4ca8e16a767258f88a450cd9a95ff7e..b80d30241162862d312e4bbae52bef3316b5d8e1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
@@ -4,8 +4,11 @@
package org.chromium.chrome.browser.ntp.cards;
+import android.support.annotation.Nullable;
+
import org.chromium.base.Callback;
import org.chromium.base.VisibleForTesting;
+import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder.PartialBindCallback;
import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
import java.util.ArrayList;
@@ -104,8 +107,9 @@ public class InnerNode extends ChildNode implements NodeParent {
}
@Override
- public void onItemRangeChanged(TreeNode child, int index, int count, Object payload) {
- notifyItemRangeChanged(getStartingOffsetForChild(child) + index, count, payload);
+ public void onItemRangeChanged(
+ TreeNode child, int index, int count, @Nullable PartialBindCallback callback) {
+ notifyItemRangeChanged(getStartingOffsetForChild(child) + index, count, callback);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698