Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java

Issue 2665983005: Ntp: use callbacks for partial binding, they can carry more detail. (Closed)
Patch Set: Address review comments from bauerb. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java
deleted file mode 100644
index def5a2a5be04b53e6bc8e54bdd0a72cf67ea6de4..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java
+++ /dev/null
@@ -1,29 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.suggestions;
-
-import android.support.annotation.IntDef;
-
-import java.lang.annotation.Retention;
-import java.lang.annotation.RetentionPolicy;
-
-/**
- * Payloads to be passed to mark the different types of partial binds that can be made on view
- * holders
- * @see org.chromium.chrome.browser.ntp.cards.InnerNode#notifyItemChanged(int, Object)
- */
-@IntDef({PartialUpdateId.OFFLINE_BADGE, PartialUpdateId.CARD_BACKGROUND})
-@Retention(RetentionPolicy.SOURCE)
-public @interface PartialUpdateId {
- /** Marks a request to update a suggestion's offline badge. */
- int OFFLINE_BADGE = 1;
-
- /**
- * Marks a request to update a card's background. Will no-op if received by a non card
- * view holder.
- * @see org.chromium.chrome.browser.ntp.cards.CardViewHolder#updateLayoutParams()
- */
- int CARD_BACKGROUND = 2;
-}

Powered by Google App Engine
This is Rietveld 408576698