third_party/WebKit/Source/core/layout/LayoutGrid.cpp - Issue 2665983004: [css-grid] Fix static position of positioned grid items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 2665983004: [css-grid] Fix static position of positioned grid items (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

index 2067dba4ca5bb552c93c4b402f9aaf3a2f135154..1c43f49fc3e6c8906d5ec08ff524b31eca1f9880 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

@@ -2601,8 +2601,8 @@ void LayoutGrid::prepareChildForPositionedLayout(LayoutBox& child) {

child.containingBlock()->insertPositionedObject(&child);

PaintLayer* childLayer = child.layer();

- childLayer->setStaticInlinePosition(borderAndPaddingStart());

- childLayer->setStaticBlockPosition(borderAndPaddingBefore());

+ childLayer->setStaticInlinePosition(LayoutUnit(borderStart()));

+ childLayer->setStaticBlockPosition(LayoutUnit(borderBefore()));

}

void LayoutGrid::layoutPositionedObjects(bool relayoutChildren,