Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: chrome/browser/resources/settings/internet_page/internet_page.js

Issue 2665913002: MD Settings: Internet: Make detail page layout more robust (Closed)
Patch Set: Feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_detail_page.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-internet-page' is the settings page containing internet 7 * 'settings-internet-page' is the settings page containing internet
8 * settings. 8 * settings.
9 */ 9 */
10 Polymer({ 10 Polymer({
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 * Reference to the bound listener, such that it can be removed on detach. 110 * Reference to the bound listener, such that it can be removed on detach.
111 * @private {Function} 111 * @private {Function}
112 */ 112 */
113 boundOnExtensionDisabled_: null, 113 boundOnExtensionDisabled_: null,
114 114
115 /** 115 /**
116 * @param {!{detail: !CrOnc.NetworkStateProperties}} event 116 * @param {!{detail: !CrOnc.NetworkStateProperties}} event
117 * @private 117 * @private
118 */ 118 */
119 onShowDetail_: function(event) { 119 onShowDetail_: function(event) {
120 settings.navigateTo( 120 var params = new URLSearchParams;
121 settings.Route.NETWORK_DETAIL, 121 params.append('guid', event.detail.GUID);
122 new URLSearchParams('guid=' + event.detail.GUID)); 122 params.append('type', event.detail.Type);
123 if (event.detail.Name)
124 params.append('name', event.detail.Name);
125 settings.navigateTo(settings.Route.NETWORK_DETAIL, params);
123 }, 126 },
124 127
125 /** 128 /**
126 * @param {!{detail: {type: string}}} event 129 * @param {!{detail: {type: string}}} event
127 * @private 130 * @private
128 */ 131 */
129 onShowKnownNetworks_: function(event) { 132 onShowKnownNetworks_: function(event) {
130 this.knownNetworksType_ = event.detail.type; 133 this.knownNetworksType_ = event.detail.type;
131 settings.navigateTo(settings.Route.KNOWN_NETWORKS); 134 settings.navigateTo(settings.Route.KNOWN_NETWORKS);
132 }, 135 },
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 }, 244 },
242 245
243 /** 246 /**
244 * @param {!chrome.networkingPrivate.ThirdPartyVPNProperties} provider 247 * @param {!chrome.networkingPrivate.ThirdPartyVPNProperties} provider
245 * @return {string} 248 * @return {string}
246 */ 249 */
247 getAddThirdParrtyVpnLabel_: function(provider) { 250 getAddThirdParrtyVpnLabel_: function(provider) {
248 return this.i18n('internetAddThirdPartyVPN', provider.ProviderName); 251 return this.i18n('internetAddThirdPartyVPN', provider.ProviderName);
249 } 252 }
250 }); 253 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_detail_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698