Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: chrome/browser/resources/settings/internet_page/internet_page.js

Issue 2665913002: MD Settings: Internet: Make detail page layout more robust (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-internet-page' is the settings page containing internet 7 * 'settings-internet-page' is the settings page containing internet
8 * settings. 8 * settings.
9 */ 9 */
10 Polymer({ 10 Polymer({
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 */ 112 */
113 boundOnExtensionDisabled_: null, 113 boundOnExtensionDisabled_: null,
114 114
115 /** 115 /**
116 * @param {!{detail: !CrOnc.NetworkStateProperties}} event 116 * @param {!{detail: !CrOnc.NetworkStateProperties}} event
117 * @private 117 * @private
118 */ 118 */
119 onShowDetail_: function(event) { 119 onShowDetail_: function(event) {
120 settings.navigateTo( 120 settings.navigateTo(
121 settings.Route.NETWORK_DETAIL, 121 settings.Route.NETWORK_DETAIL,
122 new URLSearchParams('guid=' + event.detail.GUID)); 122 new URLSearchParams(
123 'guid=' + event.detail.GUID + '&type=' + event.detail.Type +
michaelpg 2017/01/31 21:47:47 would prefer not to build this manually, see URLSe
stevenjb 2017/01/31 22:23:55 Huh, I didn't notice examples of that when I looke
124 '&name=' + event.detail.Name));
123 }, 125 },
124 126
125 /** 127 /**
126 * @param {!{detail: {type: string}}} event 128 * @param {!{detail: {type: string}}} event
127 * @private 129 * @private
128 */ 130 */
129 onShowKnownNetworks_: function(event) { 131 onShowKnownNetworks_: function(event) {
130 this.knownNetworksType_ = event.detail.type; 132 this.knownNetworksType_ = event.detail.type;
131 settings.navigateTo(settings.Route.KNOWN_NETWORKS); 133 settings.navigateTo(settings.Route.KNOWN_NETWORKS);
132 }, 134 },
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 }, 243 },
242 244
243 /** 245 /**
244 * @param {!chrome.networkingPrivate.ThirdPartyVPNProperties} provider 246 * @param {!chrome.networkingPrivate.ThirdPartyVPNProperties} provider
245 * @return {string} 247 * @return {string}
246 */ 248 */
247 getAddThirdParrtyVpnLabel_: function(provider) { 249 getAddThirdParrtyVpnLabel_: function(provider) {
248 return this.i18n('internetAddThirdPartyVPN', provider.ProviderName); 250 return this.i18n('internetAddThirdPartyVPN', provider.ProviderName);
249 } 251 }
250 }); 252 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698